Re: [PATCH] dead code and missing statics in lpfc

['Christoph Hellwig' <hch@infradead.org>]

On Tue, Jun 08, 2004 at 10:45:14AM -0400, Smart, James wrote:
> Christoph,
> 
> We had not completed the effort relative to the comments. Sorry you thought
> your patch was ignored. They (including the prior one) was not.
> 
> I believe that this week we will have completely dealt with the statics and
> symbols. One caveat though.. we have a lot of diagnostic and test tools that
> like to do low level error injection, testing, and data sampling. Our
> automated test suites are built heavily on this infrastructure. The way we
> are approaching these tools is as a separate kernel module. Therefore, the
> tools use quite a few of the "dead" symbols/functions. One of our jobs is to
> ensure that, where we sliced the interface between the driver and the tool
> module, that we did so appropriately, dead code in the driver should
> actually be in the tool module, and that we are exporting the minimum number
> of symbols. I am pushing to have this completed for the next drop as well,
> so we can put these comments to rest.

In either case exported symbols in the driver and dead symbols are completely
uninteresting for a kernel submission, so make sure you get rid of them
before you try to submit the driver.