From: Jens Axboe <axboe@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/3] scsi_forget_host - scsi_debug usage
Date: Mon, 14 Jun 2004 15:26:09 +0200 [thread overview]
Message-ID: <20040614132609.GI1970@suse.de> (raw)
In-Reply-To: <20040614132300.GA18926@infradead.org>
On Mon, Jun 14 2004, Christoph Hellwig wrote:
> On Mon, Jun 14, 2004 at 03:06:19PM +0200, Jens Axboe wrote:
> > > refcounting in place I wonder whether moving scsi_forget_host first in
> > > scsi_remove_host wouldn't simply work.
> >
> > It doesn't, device has already been deleted there. So either that needs
> > to be reworked if we want to allow devices to talk to themselves from
> > ->remove(), or we just move the sync cache call to sd_release() instead.
>
> Doing sync cache in sd_release sounds good anyway. But for the rootfs
Yep
> case we need to do it in shutdown aswell.
But the device is already SDEV_DEL there, so it can't be done without
fixing that. What makes the rootfs case special, btw?
--
Jens Axboe
next prev parent reply other threads:[~2004-06-14 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-12 4:19 [PATCH 0/3] export scsi_forget_host Mike Anderson
2004-06-12 4:21 ` [PATCH 1/3] scsi_forget_host - export function Mike Anderson
2004-06-12 4:22 ` [PATCH 2/3] scsi_forget_host - scsi_debug usage Mike Anderson
2004-06-12 4:24 ` [PATCH 3/3] scsi_forget_host - rename scsi_forget_host to scsi_unscan_host Mike Anderson
2004-06-14 8:06 ` [PATCH 2/3] scsi_forget_host - scsi_debug usage Christoph Hellwig
2004-06-14 13:06 ` Jens Axboe
2004-06-14 13:23 ` Christoph Hellwig
2004-06-14 13:26 ` Jens Axboe [this message]
2004-06-14 13:30 ` Christoph Hellwig
2004-06-14 13:36 ` Jens Axboe
2004-06-14 15:23 ` Mike Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040614132609.GI1970@suse.de \
--to=axboe@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox