From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] some tmscsim consolidation Date: Sun, 20 Jun 2004 18:21:52 +0200 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20040620162152.GA17379@lst.de> References: <20040606203314.GA4410@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([212.34.189.10]:16830 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S264367AbUFTQVy (ORCPT ); Sun, 20 Jun 2004 12:21:54 -0400 Content-Disposition: inline In-Reply-To: List-Id: linux-scsi@vger.kernel.org To: Guennadi Liakhovetski Cc: linux-scsi@vger.kernel.org On Mon, Jun 07, 2004 at 10:37:24PM +0200, Guennadi Liakhovetski wrote: > On Sun, 6 Jun 2004, Christoph Hellwig wrote: > > > On Sun, Jun 06, 2004 at 10:22:41PM +0200, Guennadi Liakhovetski wrote: > > > On Sun, 6 Jun 2004, Christoph Hellwig wrote: > > > > > > > I've looked through my old tmscsim patch queue and found this one: > > > > > > > > - merge dc390_initDCB into dc390_slave_alloc > > > > - merge DC390_release and dc390_shutdown into dc390_remove_one, > > > > use del_timer_sync to make sure the timer is really deleted on > > > > removal, adjust locking accordingly > > > > - some tiny related cleanups > > > > > > Thanks for the patch, Christoph. As you might have seen, I've already > > > submitted a patch, which merges _some_ of the functions above, following > > > > Ah sorry. It's against James' scsi-misc-2.6 tree from a day or two ago. > > I'll keep my eyes open and when I see your patch going in somewhere I'll > > resend what's left if anything. > > Thanks again! That would, certainly, be a lot easier for me. But don't > worry - there'll be enough left for you:-) I think, the only thing I've > done from the above, is merging dc390_initDCB into dc390_slave_alloc and > DC390_release into dc390_remove_one, following your suggestion of 23 May. Your patch doesn't seem to be merged yet. Maybe you need to resend it?