Re: PATCH [2/18] qla2xxx: Correct residual counts

Arjan van de Ven
2004-06-22T07:06:47Z

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

On Tue, 2004-06-22 at 07:49, Andrew Vasquez wrote:

> diff -Nru a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
> --- a/drivers/scsi/qla2xxx/qla_iocb.c 2004-06-21 15:36:37 -07:00
> +++ b/drivers/scsi/qla2xxx/qla_iocb.c 2004-06-21 15:36:37 -07:00
> @@ -43,7 +43,7 @@
> else if (cmd->sc_data_direction == DMA_FROM_DEVICE)
> cflags = CF_READ;
> else {
> - switch (cmd->data_cmnd[0]) {
> + switch (cmd->cmnd[0]) {
> case WRITE_6:
> case WRITE_10:
> case WRITE_12:

this sounds wrong. Is there any reason qlogic drivers can't use/trust
the midlayer instead of doing qla2x00_get_cmd_direction() to reverse
engineer to direction ??

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]