public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Vasquez <praka@users.sourceforge.net>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
	Andrew Vasquez <andrew.vasquez@qlogic.com>
Subject: Re: PATCH [14/18] qla2xxx: Use proper include files
Date: Tue, 22 Jun 2004 15:22:01 -0700	[thread overview]
Message-ID: <20040622222201.GA16981@praka.san.rr.com> (raw)
In-Reply-To: <20040622174900.GA14887@praka.san.rr.com>

On Tue, 22 Jun 2004, Andrew Vasquez wrote:

> Yes, in the embedded (non-failover) driver the defines are unused.
> I'll do some additional cleanup in the used areas and followup with a
> scrubbing patch during our next code drop.
> 
> In the interim, James, please apply the ACKd patch.
> 

James,

I missed a stray qla_os.h include in one of the modules, as well as
some needed #includes to compile on additional platforms.
Compile-tested and run on x86 and ppc64.

Please apply on top of previous patch.

Thanks,
Andrew Vasquez

===== drivers/scsi/qla2xxx/ql2322.c 1.2 vs edited =====
--- 1.2/drivers/scsi/qla2xxx/ql2322.c	2004-03-12 09:06:10 -08:00
+++ edited/drivers/scsi/qla2xxx/ql2322.c	2004-06-22 15:17:29
-07:00
@@ -9,7 +9,6 @@
 #include <linux/module.h>
 #include <linux/pci.h>
 
-#include "qla_os.h"
 #include "qla_def.h"
 
 static char qla_driver_name[] = "qla2322";
===== drivers/scsi/qla2xxx/qla_os.c 1.37 vs edited =====
--- 1.37/drivers/scsi/qla2xxx/qla_os.c	2004-06-22 15:16:38 -07:00
+++ edited/drivers/scsi/qla2xxx/qla_os.c	2004-06-22 15:17:45
-07:00
@@ -18,6 +18,7 @@
  */
 #include "qla_def.h"
 
+#include <linux/moduleparam.h>
 #include <linux/vmalloc.h>
 #include <linux/smp_lock.h>
 

  reply	other threads:[~2004-06-22 22:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-22 16:50 PATCH [14/18] qla2xxx: Use proper include files Andrew Vasquez
2004-06-22 17:22 ` Christoph Hellwig
2004-06-22 17:49   ` Andrew Vasquez
2004-06-22 22:22     ` Andrew Vasquez [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-06-22  5:58 Andrew Vasquez
2004-06-22  8:57 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040622222201.GA16981@praka.san.rr.com \
    --to=praka@users.sourceforge.net \
    --cc=James.Bottomley@steeleye.com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox