public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] remove CONFIG_LBD ifdefs from fusion
@ 2004-05-31 11:53 Christoph Hellwig
  2004-07-04 14:18 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2004-05-31 11:53 UTC (permalink / raw)
  To: Emoore; +Cc: linux-scsi

The CONFIG_LBD case is also fine for !CONFIG_LBD, just a bit more
complicated in the source (but the compile optimizes that away -
->bios_param isn't exactly a fast-path either..)


--- 1.41/drivers/message/fusion/mptscsih.c	2004-05-29 17:10:51 +02:00
+++ edited/drivers/message/fusion/mptscsih.c	2004-05-31 13:07:29 +02:00
@@ -3195,19 +3099,14 @@
 	int		heads;
 	int		sectors;
 	sector_t	cylinders;
-#ifdef CONFIG_LBD
 	ulong 		dummy;
-#endif
 
 	heads = 64;
 	sectors = 32;
-#ifdef CONFIG_LBD
+
 	dummy = heads * sectors;
 	cylinders = capacity;
 	sector_div(cylinders,dummy);
-#else
-	cylinders = (ulong)capacity / (heads * sectors);
-#endif
 
 	/*
 	 * Handle extended translation size for logical drives
@@ -3216,13 +3115,9 @@
 	if ((ulong)capacity >= 0x200000) {
 		heads = 255;
 		sectors = 63;
-#ifdef CONFIG_LBD
 		dummy = heads * sectors;
 		cylinders = capacity;
 		sector_div(cylinders,dummy);
-#else
-		cylinders = (ulong)capacity / (heads * sectors);
-#endif
 	}
 
 	/* return result */

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] remove CONFIG_LBD ifdefs from fusion
  2004-05-31 11:53 [PATCH] remove CONFIG_LBD ifdefs from fusion Christoph Hellwig
@ 2004-07-04 14:18 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2004-07-04 14:18 UTC (permalink / raw)
  To: Emoore; +Cc: linux-scsi

On Mon, May 31, 2004 at 01:53:48PM +0200, Christoph Hellwig wrote:
> The CONFIG_LBD case is also fine for !CONFIG_LBD, just a bit more
> complicated in the source (but the compile optimizes that away -
> ->bios_param isn't exactly a fast-path either..)

Still doesn't seem to be merged.  Here's the patch again:

--- 1.41/drivers/message/fusion/mptscsih.c	2004-05-29 17:10:51 +02:00
+++ edited/drivers/message/fusion/mptscsih.c	2004-05-31 13:07:29 +02:00
@@ -3195,19 +3099,14 @@
 	int		heads;
 	int		sectors;
 	sector_t	cylinders;
-#ifdef CONFIG_LBD
 	ulong 		dummy;
-#endif
 
 	heads = 64;
 	sectors = 32;
-#ifdef CONFIG_LBD
+
 	dummy = heads * sectors;
 	cylinders = capacity;
 	sector_div(cylinders,dummy);
-#else
-	cylinders = (ulong)capacity / (heads * sectors);
-#endif
 
 	/*
 	 * Handle extended translation size for logical drives
@@ -3216,13 +3115,9 @@
 	if ((ulong)capacity >= 0x200000) {
 		heads = 255;
 		sectors = 63;
-#ifdef CONFIG_LBD
 		dummy = heads * sectors;
 		cylinders = capacity;
 		sector_div(cylinders,dummy);
-#else
-		cylinders = (ulong)capacity / (heads * sectors);
-#endif
 	}
 
 	/* return result */

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-07-04 14:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-31 11:53 [PATCH] remove CONFIG_LBD ifdefs from fusion Christoph Hellwig
2004-07-04 14:18 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox