From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Lee Irwin III Subject: Re: [PATCH][2.6.8-rc1-mm1] drivers/scsi/sg.c gcc341 inlining fix Date: Wed, 14 Jul 2004 23:12:54 -0700 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20040715061254.GP3411@holomorphy.com> References: <200407141751.i6EHprhf009045@harpo.it.uu.se> <40F57D14.9030005@pobox.com> <20040714143508.3dc25d58.akpm@osdl.org> <20040715055655.GE9383@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from holomorphy.com ([207.189.100.168]:41634 "EHLO holomorphy.com") by vger.kernel.org with ESMTP id S266114AbUGOGNO (ORCPT ); Thu, 15 Jul 2004 02:13:14 -0400 Content-Disposition: inline In-Reply-To: <20040715055655.GE9383@suse.de> List-Id: linux-scsi@vger.kernel.org To: Jens Axboe Cc: Andrew Morton , Jeff Garzik , mikpe@csd.uu.se, B.Zolnierkiewicz@elka.pw.edu.pl, dgilbert@interlog.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Jeff Garzik wrote: >>> Or you could just call it "gcc is dumb" rather than a compiler bug. On Wed, Jul 14 2004, Andrew Morton wrote: [... code snippet ...] >> is pretty dumb too. I don't see any harm if this compiler feature/problem >> pushes us to fix the above in the obvious way. On Thu, Jul 15, 2004 at 07:56:56AM +0200, Jens Axboe wrote: > Excuse my ignorance, but why on earth would that be dumb? Looks > perfectly legit to me, and I have to agree with Jeff that the compiler > is exceedingly dumb if it fails to inline that case. Enter gcc... Maybe "the obvious way" is sending a someone off to whip gcc into shape, or possibly reporting it as a gcc problem. -- wli