From: 'Christoph Hellwig' <hch@infradead.org>
To: Jamie Wellnitz <Jamie.Wellnitz@emulex.com>
Cc: "'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>
Subject: Re: [ANNOUNCE] Emulex lpfcdriver v8.0.7 available
Date: Mon, 26 Jul 2004 14:44:50 +0100 [thread overview]
Message-ID: <20040726134450.GA25645@infradead.org> (raw)
In-Reply-To: <20040723211529.GQ20738@ma.emulex.com>
looking at your lun/target handling changes a little more:
- lpfc_find_target can lose it's last two arguments
- lpfc_findnode_scsiid can be merged into lpfc_find_target,
killing lots of dead checks.
- it looks like all the callers of lpfc_find_target in lpfc_hbadisc.c
realy want to be scsi_add_device calls, which calls lpfc_slave_alloc
meaning lpfc_find_target could be merged into that one.
- similarly your statemachine should probably call scsi_remove_device
when a target disappears.
next prev parent reply other threads:[~2004-07-26 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-23 21:15 [ANNOUNCE] Emulex lpfcdriver v8.0.7 available Jamie Wellnitz
2004-07-26 13:44 ` 'Christoph Hellwig' [this message]
2004-07-27 12:09 ` 'Christoph Hellwig'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040726134450.GA25645@infradead.org \
--to=hch@infradead.org \
--cc=Jamie.Wellnitz@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox