From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: Re: [PATCH] fix gcc 3.4 inlining errors in drivers/scsi/dc395x.c Date: Sun, 1 Aug 2004 16:15:41 +0200 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20040801141541.GO2746@fs.tum.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from hermes.fachschaften.tu-muenchen.de ([129.187.202.12]:5595 "HELO hermes.fachschaften.tu-muenchen.de") by vger.kernel.org with SMTP id S265977AbUHAOPr (ORCPT ); Sun, 1 Aug 2004 10:15:47 -0400 Content-Disposition: inline In-Reply-To: List-Id: linux-scsi@vger.kernel.org To: Jesper Juhl Cc: Andrew Morton , linux-scsi@vger.kernel.org, LKML , Oliver Neukum , Ali Akcaagac , Jamie Lenehan On Sun, Aug 01, 2004 at 02:02:50PM +0200, Jesper Juhl wrote: > > drivers/scsi/dc395x.c fails to build in 2.6.8-rc2-mm1 with gcc 3.4.0 with > the following errors : > > drivers/scsi/dc395x.c: In function `dc395x_handle_interrupt': > drivers/scsi/dc395x.c:388: sorry, unimplemented: inlining failed in call to 'enable_msgout_abort': function body not available > drivers/scsi/dc395x.c:1740: sorry, unimplemented: called from here > > drivers/scsi/dc395x.c: In function `msgin_set_async': > drivers/scsi/dc395x.c:394: sorry, unimplemented: inlining failed in call to 'set_xfer_rate': function body not available > drivers/scsi/dc395x.c:2677: sorry, unimplemented: called from here > > The patch below fixes the build by un-inlining the functions (an > alternative would be to rework the file so the functions move before their > first use). As for 'set_xfer_rate' the function itself was not declared > inline, only the prototype. >... Jamie Lenehan already ACK'ed a similar patch I sent two weeks ago which moves enable_msgout_abort instead of un-inlining it. Both approaches are feasible, it's up to the maintainers to decide which one is better in this case. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed