From: Jens Axboe <axboe@suse.de>
To: Noah Misch <noah@cs.caltech.edu>
Cc: James.Bottomley@SteelEye.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, schilling@fokus.fhg.de
Subject: Re: [PATCH] Make scsi.h nominally userspace-clean
Date: Mon, 9 Aug 2004 19:52:00 +0200 [thread overview]
Message-ID: <20040809175200.GA28126@suse.de> (raw)
In-Reply-To: <20040809172406.GA1042@orchestra.cs.caltech.edu>
On Mon, Aug 09 2004, Noah Misch wrote:
> As Joerg Schilling, the author of cdrecord, has noted in threads such as
>
> http://www.ussg.iu.edu/hypermail/linux/kernel/0309.3/1355.html and
> http://www.ussg.iu.edu/hypermail/linux/kernel/0408.0/0799.html,
>
> scsi/scsi.h does not compile cleanly in userspace programs due to its
> use of ``u8''. I have confirmed this bug and prepared and tested a
> fix that simply changes all such uses to ``__u8''. Please consider
> for inclusion.
>
> I do not argue that including this header file in a program is
> appropriate, but other kernel headers already take as many precautions
> as this patch introduces. I chose __u8 over uint8_t as more in the
> style of the kernel generally.
>
> Please keep me on cc:; I do not subscribe to the lists.
I already sent such a patch to Linus.
--
Jens Axboe
next prev parent reply other threads:[~2004-08-09 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 17:24 [PATCH] Make scsi.h nominally userspace-clean Noah Misch
2004-08-09 17:52 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-08-09 17:53 Joerg Schilling
2004-08-09 17:56 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040809175200.GA28126@suse.de \
--to=axboe@suse.de \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=noah@cs.caltech.edu \
--cc=schilling@fokus.fhg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).