From: Jens Axboe <axboe@suse.de>
To: Joerg Schilling <schilling@fokus.fraunhofer.de>
Cc: noah@cs.caltech.edu, James.Bottomley@steeleye.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Make scsi.h nominally userspace-clean
Date: Mon, 9 Aug 2004 19:56:38 +0200 [thread overview]
Message-ID: <20040809175638.GA28171@suse.de> (raw)
In-Reply-To: <200408091753.i79Hrg9q010822@burner.fokus.fraunhofer.de>
On Mon, Aug 09 2004, Joerg Schilling wrote:
> >From axboe@suse.de Mon Aug 9 19:52:11 2004
>
> >> scsi/scsi.h does not compile cleanly in userspace programs due to its
> >> use of ``u8''. I have confirmed this bug and prepared and tested a
> >> fix that simply changes all such uses to ``__u8''. Please consider
> >> for inclusion.
> >>
> >> I do not argue that including this header file in a program is
> >> appropriate, but other kernel headers already take as many precautions
> >> as this patch introduces. I chose __u8 over uint8_t as more in the
> >> style of the kernel generally.
> >>
> >> Please keep me on cc:; I do not subscribe to the lists.
>
> >I already sent such a patch to Linus.
>
> thank you! Did you also send a patch for sg.h to include linux/compiler.h?
Yes I did.
--
Jens Axboe
next prev parent reply other threads:[~2004-08-09 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 17:53 [PATCH] Make scsi.h nominally userspace-clean Joerg Schilling
2004-08-09 17:56 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-08-09 17:24 Noah Misch
2004-08-09 17:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040809175638.GA28171@suse.de \
--to=axboe@suse.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=noah@cs.caltech.edu \
--cc=schilling@fokus.fraunhofer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).