From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] add spi attributes to qla1280 Date: Thu, 12 Aug 2004 10:08:17 +0100 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20040812100817.A5988@infradead.org> References: <20040810230552.GA26569@sgi.com> <20040811081118.A26256@infradead.org> <20040811215651.GA30821@sgi.com> <20040811230555.A984@infradead.org> <20040811221636.GA31154@sgi.com> <20040811232225.A1192@infradead.org> <20040812052924.GA33167@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from imladris.demon.co.uk ([193.237.130.41]:15887 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S268473AbUHLJIT (ORCPT ); Thu, 12 Aug 2004 05:08:19 -0400 Content-Disposition: inline In-Reply-To: <20040812052924.GA33167@sgi.com>; from jeremy@sgi.com on Wed, Aug 11, 2004 at 10:29:24PM -0700 List-Id: linux-scsi@vger.kernel.org To: Jeremy Higdon Cc: linux-scsi@vger.kernel.org On Wed, Aug 11, 2004 at 10:29:24PM -0700, Jeremy Higdon wrote: > On Wed, Aug 11, 2004 at 11:22:25PM +0100, Christoph Hellwig wrote: > > On Wed, Aug 11, 2004 at 03:16:36PM -0700, Jeremy Higdon wrote: > > > > > > So I'll submit a patch to 2.6.8-rc4-mm1 then, if that's okay. > > > > Sounds good. While you're at it can you also fix the compilation > > error when the driver is compiled for port I/O instead of normal > > mmio (e.g. SGI ViswW), you broke that with your readb_relaxed changes. > > Okay. Here is the new rendition, based on 2.6.8-rc4-mm1, with the > fix for port I/O. For sync period and offset, it seems that the > isp1040 is the same as the isp1280. Looks good to me.