From: Olaf Hering <olh@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-scsi@vger.kernel.org, linuxppc64-dev@lists.linuxppc.org
Subject: Re: recent sym2 breakage
Date: Mon, 16 Aug 2004 13:37:05 +0200 [thread overview]
Message-ID: <20040816113705.GA6015@suse.de> (raw)
In-Reply-To: <20040816000146.3f484151.akpm@osdl.org>
On Mon, Aug 16, Andrew Morton wrote:
>
> So I'm putting together 2.6.8.1-mm1, which is bigger than Ben Hur and it
> seems that someone broke the sym2 driver, on ppc64 at least.
>
> It runs OK, but a `halt -p' spits nasty messages, then hangs.
sym2 is a bit flaky in 2.6.
Does the vanilla kernel work ok for you? You might need at least this
patch in case of rtas errors:
diff -purNX /suse/olh/kernel/kernel_exclude.txt linux-2.6.8.1.orig/arch/ppc64/kernel/rtas.c linux-2.6.8.1-olh/arch/ppc64/kernel/rtas.c
--- linux-2.6.8.1.orig/arch/ppc64/kernel/rtas.c 2004-08-14 12:54:50.000000000 +0200
+++ linux-2.6.8.1-olh/arch/ppc64/kernel/rtas.c 2004-08-15 19:19:49.000000000 +0200
@@ -31,6 +31,8 @@
#include <asm/delay.h>
#include <asm/uaccess.h>
+extern int mem_init_done;
+
struct flash_block_list_header rtas_firmware_flash_list = {0, NULL};
struct rtas_t rtas = {
@@ -165,6 +167,7 @@ int rtas_call(int token, int nargs, int
/* Log the error in the unlikely case that there was one. */
if (unlikely(logit)) {
+ if (mem_init_done)
buff_copy = kmalloc(RTAS_ERROR_LOG_MAX, GFP_ATOMIC);
if (buff_copy) {
memcpy(buff_copy, rtas_err_buf, RTAS_ERROR_LOG_MAX);
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2004-08-16 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-16 7:01 recent sym2 breakage Andrew Morton
2004-08-16 11:37 ` Olaf Hering [this message]
2004-08-16 11:42 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040816113705.GA6015@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox