recent sym2 breakage

recent sym2 breakage

[Andrew Morton]

So I'm putting together 2.6.8.1-mm1, which is bigger than Ben Hur and it
seems that someone broke the sym2 driver, on ppc64 at least.

It runs OK, but a `halt -p' spits nasty messages, then hangs.

Can someone suggest what changes caused this?



Shutting down network interfaces:
    eth0                                                              done
Shutting down sound driver                                            done
Shutting down service at daemon                                       done
sym0:8:0: ABORT operation started.
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: ABORT operation started.  
sym0:8:0: ABORT operation timed-out.
sym0:8:0: DEVICE RESET operation started.
sym0:8:0: DEVICE RESET operation timed-out.
sym0:8:0: BUS RESET operation started.     
sym0:8:0: BUS RESET operation timed-out.
sym0:8:0: HOST RESET operation started. 
sym0: SCSI BUS has been reset.         
                              

Re: recent sym2 breakage

[Olaf Hering]

 On Mon, Aug 16, Andrew Morton wrote:

> 
> So I'm putting together 2.6.8.1-mm1, which is bigger than Ben Hur and it
> seems that someone broke the sym2 driver, on ppc64 at least.
> 
> It runs OK, but a `halt -p' spits nasty messages, then hangs.

sym2 is a bit flaky in 2.6.

Does the vanilla kernel work ok for you? You might need at least this
patch in case of rtas errors:


diff -purNX /suse/olh/kernel/kernel_exclude.txt linux-2.6.8.1.orig/arch/ppc64/kernel/rtas.c linux-2.6.8.1-olh/arch/ppc64/kernel/rtas.c
--- linux-2.6.8.1.orig/arch/ppc64/kernel/rtas.c	2004-08-14 12:54:50.000000000 +0200
+++ linux-2.6.8.1-olh/arch/ppc64/kernel/rtas.c	2004-08-15 19:19:49.000000000 +0200
@@ -31,6 +31,8 @@
 #include <asm/delay.h>
 #include <asm/uaccess.h>
 
+extern int mem_init_done;
+
 struct flash_block_list_header rtas_firmware_flash_list = {0, NULL};
 
 struct rtas_t rtas = { 
@@ -165,6 +167,7 @@ int rtas_call(int token, int nargs, int 
 
 	/* Log the error in the unlikely case that there was one. */
 	if (unlikely(logit)) {
+		if (mem_init_done)
 		buff_copy = kmalloc(RTAS_ERROR_LOG_MAX, GFP_ATOMIC);
 		if (buff_copy) {
 			memcpy(buff_copy, rtas_err_buf, RTAS_ERROR_LOG_MAX);

-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: recent sym2 breakage

[Matthew Wilcox]

On Mon, Aug 16, 2004 at 12:01:46AM -0700, Andrew Morton wrote:
> It runs OK, but a `halt -p' spits nasty messages, then hangs.
> 
> Can someone suggest what changes caused this?

Reviewing the diff between 2.6.7 and 2.6.8.1 doesn't show any significant
changes to the sym2 driver (lots of 0/NULL changes, and ppc64 is weird,
but not /that/ weird ;-)

So it must be something sym2 is using.  The obvious candidate is the
change to drivers/scsi/scsi_transport_spi.c in the spi_dv_retrain
function.  If you pull that out, does it work better?

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain