From: Anton Blanchard <anton@samba.org>
To: Matthew Wilcox <willy@debian.org>
Cc: Olaf Hering <olh@suse.de>,
James Bottomley <James.Bottomley@SteelEye.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] fix sym2 negotiation
Date: Wed, 25 Aug 2004 22:11:29 +1000 [thread overview]
Message-ID: <20040825121129.GP2306@krispykreme> (raw)
In-Reply-To: <20040825115819.GE16196@parcelfarce.linux.theplanet.co.uk>
> > This broken chip seems to be so popular on PPC64 that the arch maintainers
> > want a PPC64 specific default. Oh well ...
> >
> > +/* Some AChip ARC765 based DVD-ROM's take 15 or more seconds
> > + * to reset. A scan will fail if made right after a reset.
> > + * It's completely broken device behaviour: SCSI specification
> > + * says devices need to be able to respond to INQUIRY always
> > + * (after a selection timeout ... of 250ms).
> > + */
> > +#ifdef __powerpc64__
> > +static unsigned int scsi_inq_timeout = SCSI_TIMEOUT/HZ+25;
> > +#else
> > static unsigned int scsi_inq_timeout = SCSI_TIMEOUT/HZ+3;
> > +#endif
> >
> > module_param_named(inq_timeout, scsi_inq_timeout, int, S_IRUGO|S_IWUSR);
> > MODULE_PARM_DESC(inq_timeout,
>
> How about hacking the ppc64 bootloader to always pass inq_timeout=30 instead?
Alternatively make scsi_inq_timeout non static and we can tweak this at
boot in ppc64 arch code. Assuming we no longer use these POS drives we
can avoid bumping the value on new machines.
Anton
next prev parent reply other threads:[~2004-08-25 12:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-21 18:37 [PATCH] fix sym2 negotiation James Bottomley
2004-08-22 17:32 ` Matthias Andree
2004-08-22 18:03 ` James Bottomley
2004-08-24 13:29 ` Olaf Hering
2004-08-24 20:39 ` Mike Anderson
2004-08-24 20:48 ` Vladimir G. Ivanovic
2004-08-24 20:50 ` Matthew Wilcox
2004-08-24 21:39 ` Vladimir G. Ivanovic
2004-08-24 22:12 ` Matthew Wilcox
2004-08-25 0:48 ` Vladimir G. Ivanovic
2004-08-24 20:51 ` Olaf Hering
2004-08-25 6:57 ` Mike Anderson
2004-08-25 9:25 ` Olaf Hering
2004-08-25 11:58 ` Matthew Wilcox
2004-08-25 12:09 ` Olaf Hering
2004-08-25 12:11 ` Anton Blanchard [this message]
2004-08-25 13:43 ` Doug Maxey
2004-08-25 13:23 ` James Bottomley
2004-08-25 19:13 ` Mike Anderson
2004-08-27 16:54 ` Kai Makisara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040825121129.GP2306@krispykreme \
--to=anton@samba.org \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=olh@suse.de \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox