Re: syslog message

Re: syslog message

[Vladimir G. Ivanovic]

[Apologies for the previous incomplete message.]

This message:

   kernel: Badness in sym_complete_error at drivers/scsi/sym53c8xx_2/sym_hipd.c:5513
   kernel:  [<82886a76>] sym_complete_error+0x96/0x233 [sym53c8xx]
   kernel:  [<8288021f>] sym53c8xx_intr+0x59/0xc5 [sym53c8xx]
   kernel:  [<021073f1>] handle_IRQ_event+0x21/0x43
   kernel:  [<02107884>] do_IRQ+0x15f/0x22e
   kernel:  =======================
   kernel:  [<021168b6>] smp_apic_timer_interrupt+0x122/0x127
   kernel:  [<02104018>] default_idle+0x0/0x2c
   kernel:  [<022d007b>] unix_stream_data_wait+0x28/0x10c
   kernel:  [<02104041>] default_idle+0x29/0x2c
   kernel:  [<0210409d>] cpu_idle+0x26/0x3b
   kernel:  [<0238d78c>] start_kernel+0x1d0/0x1d5

was in my syslog. 

I have a ASUS CUV4X-DLS motherboard (2xPIII) running Fedora Core 2
kernel (2.6.8-1.525smp)


   kernel: SCSI subsystem initialized
   kernel: sym0: <1010-33> rev 0x1 at pci 0000:00:08.0 irq 177
   kernel: sym0: using 64 bit DMA addressing
   kernel: sym0: Symbios NVRAM, ID 7, Fast-80, LVD, parity checking
   kernel: sym0: open drain IRQ line driver, using on-chip SRAM
   kernel: sym0: using LOAD/STORE-based firmware.
   kernel: sym0: handling phase mismatch from SCRIPTS.
   kernel: sym0: SCSI BUS has been reset.
   kernel: scsi0 : sym-2.1.18j
   kernel:   Vendor: QUANTUM   Model: ATLAS10K3_18_WLS  Rev: 020K
   kernel:   Type:   Direct-Access                      ANSI SCSI revision: 03
   kernel: sym0:6:0: tagged command queuing enabled, command queue depth 16.
   kernel: scsi(0:0:6:0): Beginning Domain Validation
   kernel: sym0:6: wide asynchronous.
   kernel: sym0:6: FAST-80 WIDE SCSI 160.0 MB/s DT (12.5 ns, offset 62)
   kernel: scsi(0:0:6:0): Ending Domain Validation
   kernel: SCSI device sda: 35916548 512-byte hdwr sectors (18389 MB)
   kernel: SCSI device sda: drive cache: write back
   kernel:  sda: sda1 sda2 sda3 sda4
   kernel: Attached scsi disk sda at scsi0, channel 0, id 6, lun 0

--- Vladimir

-- 
Vladimir G. Ivanovic                        http://leonora.org/~vladimir
Palo Alto, CA 94306                                      +1 650 678 8014

Re: syslog message

[Matthew Wilcox]

On Mon, Aug 30, 2004 at 10:16:36AM -0700, Vladimir G. Ivanovic wrote:
>    kernel: Badness in sym_complete_error at drivers/scsi/sym53c8xx_2/sym_hipd.c:5513

That line is:
                MDELAY(100);
which becomes:
		mdelay(100)
which is defined as:
	({unsigned long __ms=(n); while (__ms--) udelay(1000);})

Why this causes badness ...

> I have a ASUS CUV4X-DLS motherboard (2xPIII) running Fedora Core 2
> kernel (2.6.8-1.525smp)

You'd have to ask Fedora.  No doubt they have some patch that causes it.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

Re: syslog message

[Matthew Wilcox]

On Mon, Aug 30, 2004 at 10:16:36AM -0700, Vladimir G. Ivanovic wrote:
>    kernel: Badness in sym_complete_error at drivers/scsi/sym53c8xx_2/sym_hipd.c:5513
>    kernel:  [<82886a76>] sym_complete_error+0x96/0x233 [sym53c8xx]
>    kernel:  [<8288021f>] sym53c8xx_intr+0x59/0xc5 [sym53c8xx]

Did you write this down incorrectly, or was the entry for sym_interrupt
(and several other entries) missing in the kernel backtrace?  There's
several paths from sym53c8xx_intr to sym_complete_error and I really
can't tell what's going on without more information.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

Re: syslog message

[Vladimir G. Ivanovic]

>>>>> "mw" == Matthew Wilcox <willy@debian.org> writes:

    mw> 
    mw> On Mon, Aug 30, 2004 at 10:16:36AM -0700, Vladimir G. Ivanovic wrote:
    >> kernel: Badness in sym_complete_error at drivers/scsi/sym53c8xx_2/sym_hipd.c:5513
    >> kernel:  [<82886a76>] sym_complete_error+0x96/0x233 [sym53c8xx]
    >> kernel:  [<8288021f>] sym53c8xx_intr+0x59/0xc5 [sym53c8xx]
    mw> 
    mw> Did you write this down incorrectly, or was the entry for sym_interrupt
    mw> (and several other entries) missing in the kernel backtrace?  There's
    mw> several paths from sym53c8xx_intr to sym_complete_error and I really
    mw> can't tell what's going on without more information.

I copied-n-pasted this from my syslog. 

I filed a bug (#131287) with Fedora Buzilla.

--- Vladimir

-- 
Vladimir G. Ivanovic                        http://leonora.org/~vladimir
Palo Alto, CA 94306                                      +1 650 678 8014

Re: [PATCH] fix more ipr kref problems

[Brian King]

Patch looks good. Thanks.

-Brian

James Bottomley wrote:
> This was caused by
> 
> KREF: make kref_get() return void as it makes sense to do so.
>   
> drivers/scsi/ipr.c: In function `ipr_worker_thread':
> drivers/scsi/ipr.c:1825: error: wrong type argument to unary exclamation
> mark
> make[2]: *** [drivers/scsi/ipr.o] Error 1
> 
> The fix is fairly simple.
> 
> James
> 
> ===== drivers/scsi/ipr.c 1.25 vs edited =====
> --- 1.25/drivers/scsi/ipr.c	2004-08-16 01:40:17 -05:00
> +++ edited/drivers/scsi/ipr.c	2004-08-29 16:25:31 -05:00
> @@ -1822,10 +1822,11 @@
>  
>  	if (ioa_cfg->sdt_state == GET_DUMP) {
>  		dump = ioa_cfg->dump;
> -		if (!dump || !kref_get(&dump->kref)) {
> +		if (!dump) {
>  			spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
>  			return;
>  		}
> +		kref_get(&dump->kref);
>  		spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
>  		ipr_get_ioa_dump(ioa_cfg, dump);
>  		kref_put(&dump->kref, ipr_release_dump);
> @@ -2423,11 +2424,11 @@
>  	spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
>  	dump = ioa_cfg->dump;
>  
> -	if (ioa_cfg->sdt_state != DUMP_OBTAINED || !dump || !kref_get(&dump->kref)) {
> +	if (ioa_cfg->sdt_state != DUMP_OBTAINED || !dump) {
>  		spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
>  		return 0;
>  	}
> -
> +	kref_get(&dump->kref);
>  	spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
>  
>  	if (off > dump->driver_dump.hdr.len) {
> 
> 

-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center

syslog message

[Vladimir G. Ivanovic]

This
kernel: Badness in sym_complete_error at drivers/scsi/sym53c8xx_2/sym_hipd.c:5513
kernel:  [<82886a76>] sym_complete_error+0x96/0x233 [sym53c8xx]
kernel:  [<8288021f>] sym53c8xx_intr+0x59/0xc5 [sym53c8xx]
kernel:  [<021073f1>] handle_IRQ_event+0x21/0x43
kernel:  [<02107884>] do_IRQ+0x15f/0x22e
kernel:  =======================
kernel:  [<021168b6>] smp_apic_timer_interrupt+0x122/0x127
kernel:  [<02104018>] default_idle+0x0/0x2c
kernel:  [<022d007b>] unix_stream_data_wait+0x28/0x10c
kernel:  [<02104041>] default_idle+0x29/0x2c
kernel:  [<0210409d>] cpu_idle+0x26/0x3b
kernel:  [<0238d78c>] start_kernel+0x1d0/0x1d5


--- Vladimir

-- 
Vladimir G. Ivanovic                        http://leonora.org/~vladimir
Palo Alto, CA 94306                                      +1 650 678 8014