From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] tmscsim: INQUIRY always only untagged Date: Sat, 4 Sep 2004 14:01:02 +0100 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20040904140102.A15247@infradead.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from imladris.demon.co.uk ([193.237.130.41]:19718 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S267830AbUIDNBF (ORCPT ); Sat, 4 Sep 2004 09:01:05 -0400 Content-Disposition: inline In-Reply-To: ; from g.liakhovetski@gmx.de on Sat, Sep 04, 2004 at 12:41:00AM +0200 List-Id: linux-scsi@vger.kernel.org To: Guennadi Liakhovetski Cc: James Bottomley , linux-scsi@vger.kernel.org On Sat, Sep 04, 2004 at 12:41:00AM +0200, Guennadi Liakhovetski wrote: > Hello > > The attached patch makes sure, all INQUIRY commands are only sent > untagged. This way drives, affected by bug 2139, also survive further > INQUIRYs, sent after the initial scan, e.g., by scsiinfo. Looks basically good to me, but if you want to store SCSI_NO_TAG in ->TagNumber I'd suggest that you make it an unsigned type.