From: Christoph Hellwig <hch@infradead.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] tmscsim: INQUIRY always only untagged
Date: Sat, 4 Sep 2004 23:38:35 +0100 [thread overview]
Message-ID: <20040904233835.A18659@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.60.0409050022570.3092@poirot.grange>; from g.liakhovetski@gmx.de on Sun, Sep 05, 2004 at 12:26:14AM +0200
On Sun, Sep 05, 2004 at 12:26:14AM +0200, Guennadi Liakhovetski wrote:
> On Sat, 4 Sep 2004, Christoph Hellwig wrote:
>
> > On Sat, Sep 04, 2004 at 12:41:00AM +0200, Guennadi Liakhovetski wrote:
> >> Hello
> >>
> >> The attached patch makes sure, all INQUIRY commands are only sent
> >> untagged. This way drives, affected by bug 2139, also survive further
> >> INQUIRYs, sent after the initial scan, e.g., by scsiinfo.
> >
> > Looks basically good to me, but if you want to store SCSI_NO_TAG in
> > ->TagNumber I'd suggest that you make it an unsigned type.
>
> It is unsigned (u8) now. Or did you mean signed, since SCSI_NO_TAG is
> defined as (-1). I thought about making TagNumber an int, but I didn't
> bother, because it is anyway due removal...
Umm, yes signed of course.
next prev parent reply other threads:[~2004-09-04 22:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-03 22:41 [PATCH] tmscsim: INQUIRY always only untagged Guennadi Liakhovetski
2004-09-04 13:01 ` Christoph Hellwig
2004-09-04 22:26 ` Guennadi Liakhovetski
2004-09-04 22:38 ` Christoph Hellwig [this message]
2004-09-05 14:56 ` Guennadi Liakhovetski
2004-09-05 15:42 ` James Bottomley
2004-09-05 16:31 ` Christoph Hellwig
2004-09-05 20:19 ` Guennadi Liakhovetski
2004-09-06 14:34 ` James Bottomley
2004-09-05 22:22 ` James Bottomley
2004-09-06 8:50 ` Guennadi Liakhovetski
2004-09-06 9:47 ` Guennadi Liakhovetski
2004-09-06 10:01 ` Christoph Hellwig
2004-09-06 13:17 ` Guennadi Liakhovetski
2004-10-01 21:04 ` Guennadi Liakhovetski
2004-10-01 22:35 ` Christoph Hellwig
2004-10-01 22:46 ` Christoph Hellwig
2004-10-01 23:46 ` Guennadi Liakhovetski
2004-10-02 17:00 ` Guennadi Liakhovetski
2004-10-01 21:00 ` Guennadi Liakhovetski
2004-10-01 22:31 ` Christoph Hellwig
2004-10-01 23:44 ` Guennadi Liakhovetski
2004-09-15 5:30 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040904233835.A18659@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox