From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] tmscsim: INQUIRY always only untagged Date: Mon, 6 Sep 2004 11:01:50 +0100 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20040906110150.A4845@infradead.org> References: <20040904140102.A15247@infradead.org> <20040904233835.A18659@infradead.org> <1094398979.10977.9.camel@mulgrave> <20040905173134.A31521@infradead.org> <1094422949.10977.15.camel@mulgrave> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from imladris.demon.co.uk ([193.237.130.41]:63750 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S267538AbUIFKBy (ORCPT ); Mon, 6 Sep 2004 06:01:54 -0400 Content-Disposition: inline In-Reply-To: ; from g.liakhovetski@gmx.de on Mon, Sep 06, 2004 at 11:47:36AM +0200 List-Id: linux-scsi@vger.kernel.org To: Guennadi Liakhovetski Cc: James Bottomley , Christoph Hellwig , SCSI Mailing List Patch looks good to me. Two hints for a possible followon patch: > @@ -1552,15 +1520,11 @@ > pDCB->Inquiry7 =3D ptr->Flags; > =20 > ckc_e: Here we still have some INQUIRY snooping, and if you look how ptr is set you'll see it'll OOPS for machines with more than 1GB of mem= ory. > - dc390_updateDCB(pACB, pDCB); > + if (pDCB->DevMode & SYNC_NEGO_) > + pDCB->SyncMode |=3D SYNC_ENABLE; > + else { > + pDCB->SyncMode =3D 0; pDCB is memset to 0 =E5t the start of the function, so the 0 initializa= tion here isn't nessecary strictly speaking. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html