From: Christoph Hellwig <hch@infradead.org>
To: Mark Haverkamp <markh@osdl.org>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Mark Salyzyn <mark_salyzyn@adaptec.com>
Subject: Re: [PATCH] 2.6.9 aacraid: aac_count fix
Date: Tue, 14 Sep 2004 22:55:21 +0100 [thread overview]
Message-ID: <20040914225521.A13440@infradead.org> (raw)
In-Reply-To: <1095197861.25727.13.camel@markh1.pdx.osdl.net>; from markh@osdl.org on Tue, Sep 14, 2004 at 02:37:41PM -0700
On Tue, Sep 14, 2004 at 02:37:41PM -0700, Mark Haverkamp wrote:
> On Tue, 2004-09-14 at 14:14, Christoph Hellwig wrote:
> > On Tue, Sep 14, 2004 at 01:12:42PM -0700, Mark Haverkamp wrote:
> > > + for (; (unique_id < aac_count) && aac_devices[unique_id]; ++unique_id)
> > > + continue;
> > > + if (unique_id >= MAXIMUM_NUM_ADAPTERS)
> > > + goto out;
> >
> > Do we need an upper limit at all?
>
> It could be changed to have aac_devices be a **pointer and
> allocate/extend it as devices are added for more than 8 adapters. Would
> it be worth doing?
What about just using a linked list? aac_cfg_open isn't exactly a critical
fastpath.
next prev parent reply other threads:[~2004-09-14 21:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 20:12 [PATCH] 2.6.9 aacraid: aac_count fix Mark Haverkamp
2004-09-14 21:14 ` Christoph Hellwig
2004-09-14 21:37 ` Mark Haverkamp
2004-09-14 21:55 ` Christoph Hellwig [this message]
2004-09-15 14:51 ` Mark Haverkamp
-- strict thread matches above, loose matches on Subject: below --
2004-09-15 11:47 Salyzyn, Mark
2004-09-15 14:24 ` Mark Haverkamp
2004-09-16 11:29 ` Christoph Hellwig
2004-09-15 17:43 Salyzyn, Mark
2004-09-15 20:24 ` Mark Haverkamp
2004-09-16 15:14 Mark Haverkamp
2004-09-16 18:22 ` Christoph Hellwig
2004-09-16 19:12 Salyzyn, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914225521.A13440@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=markh@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox