From: Christoph Hellwig <hch@infradead.org>
To: Jeremy Higdon <jeremy@sgi.com>
Cc: linux-scsi@vger.kernel.org, patmans@us.ibm.com, axboe@suse.de,
james.bottomley@steeleye.com
Subject: Re: [RFC] [PATCH 2.6.9-rc1] add blacklist attribute indicating no ULD attach
Date: Wed, 15 Sep 2004 07:47:44 +0100 [thread overview]
Message-ID: <20040915074744.A17264@infradead.org> (raw)
In-Reply-To: <20040915031834.GA102988@sgi.com>; from jeremy@sgi.com on Tue, Sep 14, 2004 at 08:18:34PM -0700
On Tue, Sep 14, 2004 at 08:18:34PM -0700, Jeremy Higdon wrote:
> }
> + else if (*bflags & BLIST_NO_ULD_ATTACH) {
Please put the else if on the same line as the closing brace
> + sdev->no_uld_attach = 1;
> + }
don't we already carry around the blacklist flags in the scsi dev so
they could be checked laer? If not maybe we should instead of adding
more and more flags?
next prev parent reply other threads:[~2004-09-15 6:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 6:32 [RFC & PATCH 2.6.9-rc1] Add Blacklist for RAID configuration luns Jeremy Higdon
2004-09-14 14:40 ` Patrick Mansfield
2004-09-14 18:22 ` Jeremy Higdon
2004-09-15 3:18 ` [RFC] [PATCH 2.6.9-rc1] add blacklist attribute indicating no ULD attach Jeremy Higdon
2004-09-15 6:25 ` Jens Axboe
2004-09-15 6:47 ` Christoph Hellwig [this message]
2004-09-15 7:37 ` Jeremy Higdon
2004-09-15 7:40 ` Jens Axboe
2004-09-15 7:56 ` Jeremy Higdon
2004-09-15 7:59 ` Jens Axboe
2004-09-15 13:25 ` James Bottomley
2004-09-16 0:41 ` Jeremy Higdon
2004-09-16 5:42 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040915074744.A17264@infradead.org \
--to=hch@infradead.org \
--cc=axboe@suse.de \
--cc=james.bottomley@steeleye.com \
--cc=jeremy@sgi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox