From: Dave Jones <davej@redhat.com>
To: linux-scsi@vger.kernel.org
Subject: Re: fix qla2xxx inline failure.
Date: Wed, 15 Sep 2004 07:43:11 -0400 [thread overview]
Message-ID: <20040915114311.GB17683@redhat.com> (raw)
In-Reply-To: <20040915113254.GA17683@redhat.com>
There was a second failure..
drivers/scsi/qla2xxx/qla_rscn.c: In function `qla2x00_cancel_io_descriptors':
drivers/scsi/qla2xxx/qla_rscn.c:320: sorry, unimplemented: inlining failed in call to 'qla2x00_remove_iodesc_timer': function not considered for inlining
drivers/scsi/qla2xxx/qla_rscn.c:257: sorry, unimplemented: called from here
make[3]: *** [drivers/scsi/qla2xxx/qla_rscn.o] Error 1
Signed-off-by: Dave Jones <davej@redhat.com>
--- 1/drivers/scsi/qla2xxx/qla_rscn.c 2004-09-15 12:02:12.000000000 +0100
+++ 2/drivers/scsi/qla2xxx/qla_rscn.c 2004-09-15 12:41:48.504957664 +0100
@@ -242,6 +242,20 @@ qla2x00_free_iodesc(struct io_descriptor
}
/**
+ * qla2x00_remove_iodesc_timer() - Remove an active timer from an IO descriptor.
+ * @iodesc: io descriptor
+ */
+static inline void
+qla2x00_remove_iodesc_timer(struct io_descriptor *iodesc)
+{
+ if (iodesc->timer.function != NULL) {
+ del_timer_sync(&iodesc->timer);
+ iodesc->timer.data = (unsigned long) NULL;
+ iodesc->timer.function = NULL;
+ }
+}
+
+/**
* qla2x00_init_io_descriptors() - Initialize the pool of IO descriptors.
* @ha: HA context
*/
@@ -311,20 +325,6 @@ qla2x00_add_iodesc_timer(struct io_descr
add_timer(&iodesc->timer);
}
-/**
- * qla2x00_remove_iodesc_timer() - Remove an active timer from an IO descriptor.
- * @iodesc: io descriptor
- */
-static inline void
-qla2x00_remove_iodesc_timer(struct io_descriptor *iodesc)
-{
- if (iodesc->timer.function != NULL) {
- del_timer_sync(&iodesc->timer);
- iodesc->timer.data = (unsigned long) NULL;
- iodesc->timer.function = NULL;
- }
-}
-
/**
* IO descriptor support routines.
**/
prev parent reply other threads:[~2004-09-15 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 11:32 fix qla2xxx inline failure Dave Jones
2004-09-15 11:43 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040915114311.GB17683@redhat.com \
--to=davej@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox