From: Matthew Wilcox <willy@debian.org>
To: linux-scsi@vger.kernel.org
Subject: Some constants I don't understand in sym2
Date: Mon, 20 Sep 2004 21:25:35 +0100 [thread overview]
Message-ID: <20040920202535.GS642@parcelfarce.linux.theplanet.co.uk> (raw)
I'd like to convert sym2 over to using the same constants as the
rest of Linux SCSI. I think this process has uncovered a bug, but
it may simply be history that I'm missing. Here's one bit:
-#define S_GOOD (0x00)
-#define S_CHECK_COND (0x02)
[...]
+#define S_GOOD SAM_STAT_GOOD
+#define S_CHECK_COND SAM_STAT_CHECK_CONDITION
[...]
#define S_TERMINATED (0x20)
-#define S_QUEUE_FULL (0x28)
+#define S_QUEUE_FULL SAM_STAT_TASK_SET_FULL
#define S_ILLEGAL (0xff)
I don't know what S_TERMINATED should be. There's
SAM_STAT_COMMAND_TERMINATED 0x22, marked as obsolete in SAM-3. Was there
ever a TERMINATED that was 0x20, or is this simply a mistake? This same
definition can also be found in drivers/scsi/sym53c8xx_defs.h (from
the same author). aiclib.h thinks SCSI_STATUS_CMD_TERMINATED (0x22)
is obsolete in SAM-2 instead of SAM-3.
Other symbolic tags I haven't found Linux names for yet include:
#define M_ABORT_TAG (0x0d)
#define M_CLEAR_QUEUE (0x0e)
-#define M_INIT_REC (0x0f)
-#define M_REL_REC (0x10)
+#define M_INIT_REC INITIATE_RECOVERY
+#define M_REL_REC RELEASE_RECOVERY
#define M_TERMINATE (0x11)
#define M_IGN_RESIDUE (0x23)
#define M_IDENTIFY (0x80)
Again, history lesson / pointers to specs appreciated (I have sam3r09,
spc3r15 and spi5r06 handy).
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next reply other threads:[~2004-09-20 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-20 20:25 Matthew Wilcox [this message]
2004-09-20 21:12 ` Some constants I don't understand in sym2 Tony Battersby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040920202535.GS642@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox