From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@debian.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Add SPI-5 constants to scsi.h
Date: Tue, 21 Sep 2004 13:04:38 +0100 [thread overview]
Message-ID: <20040921130438.A22311@infradead.org> (raw)
In-Reply-To: <20040921115059.GU642@parcelfarce.linux.theplanet.co.uk>; from willy@debian.org on Tue, Sep 21, 2004 at 12:50:59PM +0100
On Tue, Sep 21, 2004 at 12:50:59PM +0100, Matthew Wilcox wrote:
>
> Add the new constant names from SPI-5 to <scsi/scsi.h>
<nitpick>
What about having a section ala
/*
* Old SCSI2 names, don't use in new code
*/
#define ABORT ABORT_TASK_SET
#define BUS_DEVICE_RESET TARGET_RESET
instead of intermixing them with the rest of the defines?
</nitpick>
next prev parent reply other threads:[~2004-09-21 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-21 11:50 [PATCH] Add SPI-5 constants to scsi.h Matthew Wilcox
2004-09-21 12:04 ` Christoph Hellwig [this message]
2004-09-21 12:31 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040921130438.A22311@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox