Re: BUG: CD driver sends command during host removal

Mike Anderson
2004-10-11T23:13:23Z

James Bottomley [James.Bottomley@SteelEye.com] wrote:
> On Mon, 2004-10-11 at 15:40, Mike Anderson wrote:
> > > This is the remove implies cancel issue that was discussed earlier. I
> > > thought the proposal was to have a remove that wouldn't automatically
> > > cancel all the commands? ... although I don't think I've seen any code
> > > for that case yet.
> > >
> >
> > Clarification. James, are you indicating that there needs to be a new
> > scsi mid api that performs similar function to scsi_remove_host expect
> > does not cancel commands?
>
> Sorry, by "a remove that .." I was meaning "another remove method that
> ..."
>

Well based on Mike C's mail it looks like when I moved scsi_forget_host
up in scsi_remove_host that I broke scsi_host_cancel as it stands now
scsi_remove_host is not really doing any cancels.

http://marc.theaimsgroup.com/?l=linux-scsi&m=109743460011434&w=2

> > If is unclear to me if a LLDD provides a slave_destroy which is called
> > from scsi_remove_device during the scsi_forget_host function that we
> > would hit a case where the LLDD has good IO to complete still
> > outstanding when we complete scsi_forget_host and call scsi_host_cancel.
>
> That depends what the LLD does with the slave destroy really. The API
> doesn't say the LLD has to chase all I/Os down when slave destroy is
> called, so we can't assume it has.
>

ok.

-andmike
--
Michael Anderson
andmike@us.ibm.com