Re: [RFC PATCH 2.6.9-rc2] add ability to set device queue depth to mptfusion

[Matthew Wilcox <matthew@wil.cx>]

On Tue, Sep 28, 2004 at 11:48:14AM +0100, Christoph Hellwig wrote:
> > +			else if (((pTarget->inq_data[0] & 0x1f) == 0x00)
> > +			  && (pTarget->minSyncFactor <= MPT_ULTRA160 ))
> 
> 
> 			else if (!(pTarget->inq_data[0] & 0x1f) &&
> 				 (pTarget->minSyncFactor <= MPT_ULTRA160)

I'm not sure about converting
	if ((pTarget->inq_data[0] & 0x1f) == 0x00)
to
	if (!(pTarget->inq_data[0] & 0x1f))

It really depends on the semantics -- in this case I think it's "this 5
bit field has the value 0", rather than "this field is not set".  It's the
same reason I hate people using if (!strcmp()) -- it's not that strcmp()
failed, it's that it returned 0.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain