From: Christoph Hellwig <hch@infradead.org>
To: Jeremy Higdon <jeremy@sgi.com>
Cc: Emoore@lsil.com, linux-scsi@vger.kernel.org
Subject: Re: [RFC PATCH 2.6.9-rc2] add ability to set device queue depth to mptfusion
Date: Tue, 28 Sep 2004 11:48:14 +0100 [thread overview]
Message-ID: <20040928114814.A794@infradead.org> (raw)
In-Reply-To: <20040928075846.GA190230@sgi.com>; from jeremy@sgi.com on Tue, Sep 28, 2004 at 12:58:47AM -0700
Code looks good but some style nitpicks (often inherited from the original
code):
> +static void
> +mptscsih_set_queue_depth(struct scsi_device *device, MPT_SCSI_HOST *hd, VirtDevice *pTarget, int qdepth)
linebreaks after 80characters please.
> + if ( hd->is_spi ) {
if (hdis_spi) {
> + else if (((pTarget->inq_data[0] & 0x1f) == 0x00)
> + && (pTarget->minSyncFactor <= MPT_ULTRA160 ))
else if (!(pTarget->inq_data[0] & 0x1f) &&
(pTarget->minSyncFactor <= MPT_ULTRA160)
> + }
> + else
} else
next prev parent reply other threads:[~2004-09-28 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-28 7:58 [RFC PATCH 2.6.9-rc2] add ability to set device queue depth to mptfusion Jeremy Higdon
2004-09-28 10:48 ` Christoph Hellwig [this message]
2004-09-28 11:43 ` Matthew Wilcox
2004-09-28 23:47 ` Jeremy Higdon
2004-09-29 0:14 ` Jeremy Higdon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040928114814.A794@infradead.org \
--to=hch@infradead.org \
--cc=Emoore@lsil.com \
--cc=jeremy@sgi.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox