Re: [PATCH] tmscsim: INQUIRY always only untagged

James Bottomley
2004-09-05T22:22:34Z

On Sun, 2004-09-05 at 12:31, Christoph Hellwig wrote:
> Umm yes. But lets get the driver no oops first and then move forward.
> There's still a lot of work to do on the driver.

Well, OK. I agree to putting a palliative fix in, since what I
suggested will probably take more thought, but I don't think this one is
actually it. Mixing tagged and untagged commands is illegal under the
SCSI spec. Simply untagging the INQUIRY command may work to fix this
particular bug, but I bet it will introduce others when a scsi utility
sends an INQUIRY down to an in-use device.

I think perhaps the correct palliative fix is simply to list this device
(whatever it is, it's not listed in the bug report) as BLIST_NOTQ, then
the problem won't arise (and of course, tmscsim would have actually to
use the mid-layer black list rather than its own much shorter internal
list).

James