Re: [PATCH] tmscsim: INQUIRY always only untagged

Christoph Hellwig
2004-09-04T22:38:39Z

On Sun, Sep 05, 2004 at 12:26:14AM +0200, Guennadi Liakhovetski wrote:
> On Sat, 4 Sep 2004, Christoph Hellwig wrote:
>
> > On Sat, Sep 04, 2004 at 12:41:00AM +0200, Guennadi Liakhovetski wrote:
> >> Hello
> >>
> >> The attached patch makes sure, all INQUIRY commands are only sent
> >> untagged. This way drives, affected by bug 2139, also survive further
> >> INQUIRYs, sent after the initial scan, e.g., by scsiinfo.
> >
> > Looks basically good to me, but if you want to store SCSI_NO_TAG in
> > ->TagNumber I'd suggest that you make it an unsigned type.
>
> It is unsigned (u8) now. Or did you mean signed, since SCSI_NO_TAG is
> defined as (-1). I thought about making TagNumber an int, but I didn't
> bother, because it is anyway due removal...

Umm, yes signed of course.