Re: [PATCH] tmscsim: INQUIRY always only untagged

Guennadi Liakhovetski
2004-09-06T05:50:54Z

On Sun, 5 Sep 2004, Christoph Hellwig wrote:

> On Sun, Sep 05, 2004 at 11:42:58AM -0400, James Bottomley wrote:
>> On Sun, 2004-09-05 at 10:56, Guennadi Liakhovetski wrote:
>>> Ok, how about the attached version?
>>
>> Well, it looks like it would cure the symptoms, and I can apply it as a
>> palliative.
>>
>> However, the disease in this driver is that it snoops the inquiry data
>> and gets confused by the double inquiry we now do for certain drives.
>>
>> What really needs to happen is
>>
>> 1) remove the inquiry snooping and believe the flags in struct
>> scsi_device instead

...and use tags set up by the block layer...

>> 2) Don't turn on TCQ until slave_configure()

Well, this alone wouldn't help with this specific problem, exactly because
INQUIRY can be sent later too. Or would the mid-layer completely disable
tagging for such a disk?

>> 3) remove it's internal TCQ black list and put it at the mid-layer.
>
> Umm yes. But lets get the driver no oops first and then move forward.
> There's still a lot of work to do on the driver.

Thanks