Re: [PATCH] tmscsim: INQUIRY always only untagged

Guennadi Liakhovetski
2004-10-01T22:20:30Z

On Mon, 6 Sep 2004, Guennadi Liakhovetski wrote:

> On Mon, 5 Sep 2004, James Bottomley wrote:
>
>> I think perhaps the correct palliative fix is simply to list this device
>> (whatever it is, it's not listed in the bug report) as BLIST_NOTQ, then
>> the problem won't arise (and of course, tmscsim would have actually to
>> use the mid-layer black list rather than its own much shorter internal
>> list).
>
> I don't know what device the original reporter had, but the one I have here,
> which exibits the same behaviour, is a Seagate disk (see attached patch). So,
> if you still think, this device should not be allowed any tags (which is a
> pity, I would then again have no device with tags supported for tests
> here:-(), then, please, apply the attached patch. A patch to use the
> blacklist will follow shortly.

Looks like this patch didn't get applied until now. Have you changed your
opinion about the proper handling of this disk, James, or it just somehow
got lost? Attaching again below. Next patch to tmscsim will switch the
driver to use the device information from the mid-layer, so, this patch is
required.

Thanks
Guennadi
---
Guennadi Liakhovetski

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

diff -u a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
--- a/drivers/scsi/scsi_devinfo.c Mon Sep 6 10:37:08 2004
+++ b/drivers/scsi/scsi_devinfo.c Mon Sep 6 10:36:30 2004
@@ -181,6 +181,7 @@
{"REGAL", "CDC-4X", NULL, BLIST_MAX5LUN | BLIST_SINGLELUN},
{"SanDisk", "ImageMate CF-SD1", NULL, BLIST_FORCELUN},
{"SEAGATE", "ST3390N", "9546", BLIST_NOTQ},
+ {"SEAGATE", "ST34555N", "0930", BLIST_NOTQ}, /* Chokes on tagged INQUIRY */
{"SGI", "RAID3", "*", BLIST_SPARSELUN},
{"SGI", "RAID5", "*", BLIST_SPARSELUN},
{"SGI", "TP9100", "*", BLIST_REPORTLUN2},