Re: [PATCH] tmscsim: INQUIRY always only untagged

Christoph Hellwig
2004-10-01T22:31:56Z

On Fri, Oct 01, 2004 at 11:00:23PM +0200, Guennadi Liakhovetski wrote:
> On Mon, 6 Sep 2004, Guennadi Liakhovetski wrote:
>
> > On Mon, 5 Sep 2004, James Bottomley wrote:
> >
> >> I think perhaps the correct palliative fix is simply to list this device
> >> (whatever it is, it's not listed in the bug report) as BLIST_NOTQ, then
> >> the problem won't arise (and of course, tmscsim would have actually to
> >> use the mid-layer black list rather than its own much shorter internal
> >> list).
> >
> > I don't know what device the original reporter had, but the one I have here,
> > which exibits the same behaviour, is a Seagate disk (see attached patch). So,
> > if you still think, this device should not be allowed any tags (which is a
> > pity, I would then again have no device with tags supported for tests
> > here:-(), then, please, apply the attached patch. A patch to use the
> > blacklist will follow shortly.
>
> Looks like this patch didn't get applied until now. Have you changed your
> opinion about the proper handling of this disk, James, or it just somehow
> got lost? Attaching again below. Next patch to tmscsim will switch the
> driver to use the device information from the mid-layer, so, this patch is
> required.

I get rejects in every single hunk when trying to apply your patches. It
looks like some kind of whitespace messup, but I don't see in what way.

Did you recently switch mailers?