Re: [PATCH] tmscsim: INQUIRY always only untagged

James Bottomley
2004-09-06T14:34:29Z

On Sun, 2004-09-05 at 16:19, Guennadi Liakhovetski wrote:
> >> 1) remove the inquiry snooping and believe the flags in struct
> >> scsi_device instead
>
> ...and use tags set up by the block layer...

Well, yes, that too ... it depends how much time anyone has to spend on
this driver.

> >> 2) Don't turn on TCQ until slave_configure()
>
> Well, this alone wouldn't help with this specific problem, exactly because
> INQUIRY can be sent later too. Or would the mid-layer completely disable
> tagging for such a disk?

The bug report claims 2.4 works, so probably there the device itself
will still screw up if another inquiry were sent as part of the tagged
stream, I think (perhaps it doesn't, someone needs to check). However,
turning on TCQ in slave_configure() will mean that the two initial
inquiries are sent untagged, so it will only manifest in 2.6 in the same
circumstances as 2.4.

James