Re: [PATCH] tmscsim: INQUIRY always only untagged

Christoph Hellwig
2004-09-06T10:01:54Z

Patch looks good to me. Two hints for a possible followon patch:

> @@ -1552,15 +1520,11 @@
> pDCB->Inquiry7 = ptr->Flags;
>
> ckc_e:

Here we still have some INQUIRY snooping, and if you look how
ptr is set you'll see it'll OOPS for machines with more than 1GB of memory.

> - dc390_updateDCB(pACB, pDCB);
> + if (pDCB->DevMode & SYNC_NEGO_)
> + pDCB->SyncMode |= SYNC_ENABLE;
> + else {
> + pDCB->SyncMode = 0;

pDCB is memset to 0 åt the start of the function, so the 0 initialization
here isn't nessecary strictly speaking.

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html