Re: [PATCH] tmscsim: INQUIRY always only untagged

Christoph Hellwig
2004-09-05T16:31:37Z

On Sun, Sep 05, 2004 at 11:42:58AM -0400, James Bottomley wrote:
> On Sun, 2004-09-05 at 10:56, Guennadi Liakhovetski wrote:
> > Ok, how about the attached version?
>
> Well, it looks like it would cure the symptoms, and I can apply it as a
> palliative.
>
> However, the disease in this driver is that it snoops the inquiry data
> and gets confused by the double inquiry we now do for certain drives.
>
> What really needs to happen is
>
> 1) remove the inquiry snooping and believe the flags in struct
> scsi_device instead
> 2) Don't turn on TCQ until slave_configure()
> 3) remove it's internal TCQ black list and put it at the mid-layer.

Umm yes. But lets get the driver no oops first and then move forward.
There's still a lot of work to do on the driver.