From: Christoph Hellwig <hch@infradead.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] tmscsim: INQUIRY always only untagged
Date: Fri, 1 Oct 2004 23:46:06 +0100 [thread overview]
Message-ID: <20041001234606.A9024@infradead.org> (raw)
In-Reply-To: <20041001233554.B8853@infradead.org>; from hch@infradead.org on Fri, Oct 01, 2004 at 11:35:54PM +0100
On Fri, Oct 01, 2004 at 11:35:54PM +0100, Christoph Hellwig wrote:
> > + if (pcmd->cmnd[0] == INQUIRY &&
> > + (pcmd->result == (DID_OK << 16) || status_byte(pcmd->result) & CHECK_CONDITION) &&
> > + (ptr->DevType & SCSI_DEVTYPE) != TYPE_NODEV)
> > + /* device found: add */
> > + pDCB->DevType = ptr->DevType & SCSI_DEVTYPE;
>
> instead of ptr->DevType you can use the 'device' field in struct scsi_device.
> In fact the dcb DevType field should go away aswell in favour of that one.
And while we're at it: The whole inquiry sniffing in dc390_SRBdone (aka all
uses of ptr and ptr) can easily go away if you kill pDCB->Inquiry7 and check
sdev->sdtr instead.
next prev parent reply other threads:[~2004-10-01 22:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-03 22:41 [PATCH] tmscsim: INQUIRY always only untagged Guennadi Liakhovetski
2004-09-04 13:01 ` Christoph Hellwig
2004-09-04 22:26 ` Guennadi Liakhovetski
2004-09-04 22:38 ` Christoph Hellwig
2004-09-05 14:56 ` Guennadi Liakhovetski
2004-09-05 15:42 ` James Bottomley
2004-09-05 16:31 ` Christoph Hellwig
2004-09-05 20:19 ` Guennadi Liakhovetski
2004-09-06 14:34 ` James Bottomley
2004-09-05 22:22 ` James Bottomley
2004-09-06 8:50 ` Guennadi Liakhovetski
2004-09-06 9:47 ` Guennadi Liakhovetski
2004-09-06 10:01 ` Christoph Hellwig
2004-09-06 13:17 ` Guennadi Liakhovetski
2004-10-01 21:04 ` Guennadi Liakhovetski
2004-10-01 22:35 ` Christoph Hellwig
2004-10-01 22:46 ` Christoph Hellwig [this message]
2004-10-01 23:46 ` Guennadi Liakhovetski
2004-10-02 17:00 ` Guennadi Liakhovetski
2004-10-01 21:00 ` Guennadi Liakhovetski
2004-10-01 22:31 ` Christoph Hellwig
2004-10-01 23:44 ` Guennadi Liakhovetski
2004-09-15 5:30 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041001234606.A9024@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox