Re: sym2 on sparc

[Matthew Wilcox <matthew@wil.cx>]

On Sat, Oct 02, 2004 at 09:33:13AM -0400, James Bottomley wrote:
> On Fri, 2004-10-01 at 14:20, Matthew Wilcox wrote:
> > Could someone with a symbios 53c8xx chip test this patch?  It works
> > on non-sparc.  If I don't hear of any problems, it'll be in the next
> > driver update.
> 
> Do we have to do this?

DaveM sent me a reply saying:

> Just print the IRQ out as an unsigned integer, it's not the
> end of the world if you don't use the special sparc macros.

Again, sorry about the list address confusion.

> Putting architecture specific knowledge into a device driver is almost
> never a good thing to do.  If all you want to do is print out the IRQ
> designation, I suspect this is a generic problem, not a sym2 specific
> problem, so what we need is something like an irq_to_string()
> abstraction.

I agree.  We could probably use something similar on PA-RISC.  There's
about 25 drivers in-tree that're currently using __irq_itoa().  Most
of them would be better-written if everybody were using a string.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain