Re: [PATCH] scsi_debug [was: scsi_debug issues]

[Nishanth Aravamudan <nacc@us.ibm.com>]

On Tue, Oct 19, 2004 at 08:05:53AM +1000, Douglas Gilbert wrote:
> Nishanth Aravamudan wrote:
> >On Mon, Oct 18, 2004 at 11:44:59PM +1000, Douglas Gilbert wrote:
> >
> >>James Bottomley wrote:
> >>
> >>>On Sat, 2004-10-16 at 01:51, Douglas Gilbert wrote:
> >>>
> >>>
> >>>>So this problem seems related to highmem.
> >
> >
> ><snip>
> >
> >>The above required a fair few changes to scsi_debug.
> >>Attached is a patch that rolls "kmap" changes with
> >>patches I have sent recently for scsi_debug.
> >>Attachment is gzipped (due to size) and applies against
> >>lk 2.6.8.1 -> lk 2.6.9-rc4 .
> >>
> >>Nishanth, could you test this with highmem?
> >
> >
> >Doug,
> >
> >I ran 2.6.9-rc4 with your patch applied and had several dump_stack()s
> >occur (complaining about sleeping in an invalid context) and a final
> >panic during mkfs :) I think something is still wrong... ;) Output is
> >below and attached.
> 
> Ok, it looks like kmap_atomic() is needed.
> Could you try this additional patch.

Great! That patch seems to have fixed it. I am able to vi files, sync
the scsi_debug 'disks' and not have any hangs. It is noticeably slower,
though, it seems. Might that just be a side effect of the atomic calls?

Thanks again!

-Nish