From: Jens Axboe <axboe@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Ben Collins <bcollins@debian.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dtor_core@ameritech.net>,
James Bottomley <James.Bottomley@SteelEye.com>,
Andrew Morton <akpm@osdl.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
willy@debian.org,
Linux1394-Devel <linux1394-devel@lists.sourceforge.net>
Subject: Re: [BK PATCH] SCSI updates for 2.6.9
Date: Tue, 19 Oct 2004 10:03:13 +0200 [thread overview]
Message-ID: <20041019080313.GP2284@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0410190009260.2287@ppc970.osdl.org>
On Tue, Oct 19 2004, Linus Torvalds wrote:
>
> Ben,
> does this look ok to you?
>
> Arguably the SCSI layer should also have proper prefixes for its constants
> - and in fact they do kind of exist as the GPCMD_xxx constants. Oh, well.
> Regardless, the sbp2 constants do look like they want prefixing..
But only for commands (GPCMD is general packet command), not for
anything else. Would be nice to standardize prefixes for other things,
too.
--
Jens Axboe
next prev parent reply other threads:[~2004-10-19 8:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-18 22:03 [BK PATCH] SCSI updates for 2.6.9 James Bottomley
2004-10-19 0:30 ` K.R. Foley
2004-10-19 4:41 ` Dmitry Torokhov
2004-10-19 5:05 ` Andrew Morton
2004-10-19 5:12 ` Dmitry Torokhov
2004-10-19 7:13 ` Linus Torvalds
2004-10-19 7:42 ` Ben Collins
2004-10-19 8:03 ` Jens Axboe [this message]
2004-10-19 13:54 ` James Bottomley
2004-10-19 16:17 ` Matthew Wilcox
2004-10-20 23:22 ` Douglas Gilbert
2004-10-22 17:52 ` Linus Torvalds
2004-10-22 19:46 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041019080313.GP2284@suse.de \
--to=axboe@suse.de \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=bcollins@debian.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=torvalds@osdl.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).