linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: 'Dave Olien' <dmo@osdl.org>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] fix for Incorrect number of segments after building list problem
Date: Wed, 20 Oct 2004 18:11:40 +0200	[thread overview]
Message-ID: <20041020161139.GR10531@suse.de> (raw)
In-Reply-To: <1098288465.2008.13.camel@mulgrave>

On Wed, Oct 20 2004, James Bottomley wrote:
> On Wed, 2004-10-20 at 10:58, Jens Axboe wrote:
> > Ah yes, now I remember. How is the fix for that coming along, btw?
> 
> Erm, it didn't cross my mind until I realised what this problem was
> about.  All SCSI drivers are setting 65536 (the default) for the max
> segment length.  However, this is being violated wholesale by all the
> IOMMUs and it all works because their length descriptors are 32 bit
> anyway ...
> 
> However, I'll add it to the list and see if I can get something out.  My
> slight problem is testing.  Only SATA and IDE have this short descriptor
> problem, so I've nothing really to test the actual fix with.

Just set some articial limit (say, 0x3fff) and add a debug check in
init_io() to check the violation?

-- 
Jens Axboe


  reply	other threads:[~2004-10-20 16:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-14 21:51 [PATCH] fix for Incorrect number of segments after building list problem James Bottomley
2004-10-14 21:55 ` 'Dave Olien'
2004-10-14 22:15 ` 'Dave Olien'
2004-10-14 22:51   ` 'Dave Olien'
2004-10-20 14:39 ` Jens Axboe
2004-10-20 15:07   ` Jens Axboe
2004-10-20 15:50     ` James Bottomley
2004-10-20 15:58       ` Jens Axboe
2004-10-20 16:07         ` James Bottomley
2004-10-20 16:11           ` Jens Axboe [this message]
2004-10-20 17:45           ` Jeff Garzik
2004-10-20 17:47             ` Jens Axboe
2004-10-20 18:11               ` Jeff Garzik
2004-10-21 12:49               ` James Bottomley
2004-10-21 13:02                 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041020161139.GR10531@suse.de \
    --to=axboe@suse.de \
    --cc=James.Bottomley@SteelEye.com \
    --cc=dmo@osdl.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).