From: Christoph Hellwig <hch@lst.de>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: hch@lst.de, dafastidio@libero.it, linux-scsi@vger.kernel.org
Subject: Re: [Trivial PATCH 2.6.9-bk5] dmx3191d.c lacked MODULE_DEVICE_TABLE()
Date: Thu, 21 Oct 2004 09:58:55 +0200 [thread overview]
Message-ID: <20041021075855.GA24574@lst.de> (raw)
In-Reply-To: <200410212251.i9LMpsm13032@freya.yggdrasil.com>
On Thu, Oct 21, 2004 at 03:51:54PM -0700, Adam J. Richter wrote:
> Hi Christoph,
>
> Thank you for porting dmx3191d.c to the modern PCI driver
> interface. Here is a one line patch to correct a minor oversight.
> You omitted the MODULE_DEVICE_TABLE() declaration, which is used
> by boot and hot plug facilities to load the module when the hardware
> is present. Could you please forward it downstream if it looks
> OK to you? Thanks in advance.
Sure - James, can you apply that little patch?
>
>
> __ ______________
> Adam J. Richter \ /
> adam@yggdrasil.com | g g d r a s i l
>
> --- linux-2.6.9-bk5/drivers/scsi/dmx3191d.c 2004-10-21 12:01:55.000000000 -0700
> +++ linux/drivers/scsi/dmx3191d.c 2004-10-21 15:21:02.000000000 -0700
> @@ -146,6 +146,7 @@
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4},
> { }
> };
> +MODULE_DEVICE_TABLE(pci, dmx3191d_pci_tbl);
>
> static struct pci_driver dmx3191d_pci_driver = {
> .name = DMX3191D_DRIVER_NAME,
---end quoted text---
prev parent reply other threads:[~2004-10-21 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 22:51 [Trivial PATCH 2.6.9-bk5] dmx3191d.c lacked MODULE_DEVICE_TABLE() Adam J. Richter
2004-10-21 7:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041021075855.GA24574@lst.de \
--to=hch@lst.de \
--cc=adam@yggdrasil.com \
--cc=dafastidio@libero.it \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).