From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [Trivial PATCH 2.6.9-bk5] dmx3191d.c lacked MODULE_DEVICE_TABLE() Date: Thu, 21 Oct 2004 09:58:55 +0200 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20041021075855.GA24574@lst.de> References: <200410212251.i9LMpsm13032@freya.yggdrasil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.210]:9385 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S270077AbUJUH7E (ORCPT ); Thu, 21 Oct 2004 03:59:04 -0400 Content-Disposition: inline In-Reply-To: <200410212251.i9LMpsm13032@freya.yggdrasil.com> List-Id: linux-scsi@vger.kernel.org To: "Adam J. Richter" Cc: hch@lst.de, dafastidio@libero.it, linux-scsi@vger.kernel.org On Thu, Oct 21, 2004 at 03:51:54PM -0700, Adam J. Richter wrote: > Hi Christoph, > > Thank you for porting dmx3191d.c to the modern PCI driver > interface. Here is a one line patch to correct a minor oversight. > You omitted the MODULE_DEVICE_TABLE() declaration, which is used > by boot and hot plug facilities to load the module when the hardware > is present. Could you please forward it downstream if it looks > OK to you? Thanks in advance. Sure - James, can you apply that little patch? > > > __ ______________ > Adam J. Richter \ / > adam@yggdrasil.com | g g d r a s i l > > --- linux-2.6.9-bk5/drivers/scsi/dmx3191d.c 2004-10-21 12:01:55.000000000 -0700 > +++ linux/drivers/scsi/dmx3191d.c 2004-10-21 15:21:02.000000000 -0700 > @@ -146,6 +146,7 @@ > PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4}, > { } > }; > +MODULE_DEVICE_TABLE(pci, dmx3191d_pci_tbl); > > static struct pci_driver dmx3191d_pci_driver = { > .name = DMX3191D_DRIVER_NAME, ---end quoted text---