* [Trivial PATCH 2.6.9-bk5] dmx3191d.c lacked MODULE_DEVICE_TABLE()
@ 2004-10-21 22:51 Adam J. Richter
2004-10-21 7:58 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Adam J. Richter @ 2004-10-21 22:51 UTC (permalink / raw)
To: hch; +Cc: dafastidio, linux-scsi
Hi Christoph,
Thank you for porting dmx3191d.c to the modern PCI driver
interface. Here is a one line patch to correct a minor oversight.
You omitted the MODULE_DEVICE_TABLE() declaration, which is used
by boot and hot plug facilities to load the module when the hardware
is present. Could you please forward it downstream if it looks
OK to you? Thanks in advance.
__ ______________
Adam J. Richter \ /
adam@yggdrasil.com | g g d r a s i l
--- linux-2.6.9-bk5/drivers/scsi/dmx3191d.c 2004-10-21 12:01:55.000000000 -0700
+++ linux/drivers/scsi/dmx3191d.c 2004-10-21 15:21:02.000000000 -0700
@@ -146,6 +146,7 @@
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4},
{ }
};
+MODULE_DEVICE_TABLE(pci, dmx3191d_pci_tbl);
static struct pci_driver dmx3191d_pci_driver = {
.name = DMX3191D_DRIVER_NAME,
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Trivial PATCH 2.6.9-bk5] dmx3191d.c lacked MODULE_DEVICE_TABLE()
2004-10-21 22:51 [Trivial PATCH 2.6.9-bk5] dmx3191d.c lacked MODULE_DEVICE_TABLE() Adam J. Richter
@ 2004-10-21 7:58 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2004-10-21 7:58 UTC (permalink / raw)
To: Adam J. Richter; +Cc: hch, dafastidio, linux-scsi
On Thu, Oct 21, 2004 at 03:51:54PM -0700, Adam J. Richter wrote:
> Hi Christoph,
>
> Thank you for porting dmx3191d.c to the modern PCI driver
> interface. Here is a one line patch to correct a minor oversight.
> You omitted the MODULE_DEVICE_TABLE() declaration, which is used
> by boot and hot plug facilities to load the module when the hardware
> is present. Could you please forward it downstream if it looks
> OK to you? Thanks in advance.
Sure - James, can you apply that little patch?
>
>
> __ ______________
> Adam J. Richter \ /
> adam@yggdrasil.com | g g d r a s i l
>
> --- linux-2.6.9-bk5/drivers/scsi/dmx3191d.c 2004-10-21 12:01:55.000000000 -0700
> +++ linux/drivers/scsi/dmx3191d.c 2004-10-21 15:21:02.000000000 -0700
> @@ -146,6 +146,7 @@
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4},
> { }
> };
> +MODULE_DEVICE_TABLE(pci, dmx3191d_pci_tbl);
>
> static struct pci_driver dmx3191d_pci_driver = {
> .name = DMX3191D_DRIVER_NAME,
---end quoted text---
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-21 7:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-21 22:51 [Trivial PATCH 2.6.9-bk5] dmx3191d.c lacked MODULE_DEVICE_TABLE() Adam J. Richter
2004-10-21 7:58 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).