From: Christoph Hellwig <hch@lst.de>
To: "Moore, Eric Dean" <Emoore@lsil.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fusion: streamline ->slave_alloc/->slave_destroy
Date: Thu, 21 Oct 2004 11:09:40 +0200 [thread overview]
Message-ID: <20041021090940.GC25645@lst.de> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E5705262988@exa-atlanta>
On Mon, Oct 11, 2004 at 02:39:54PM -0400, Moore, Eric Dean wrote:
> > > > - hd = (MPT_SCSI_HOST *)host->hostdata;
> > > > + mptscsih_search_running_cmds(hd, target, lun);
> > > >
> > > > - if (hd == NULL)
> > > > + vdev->luns[0] &= ~(1 << lun);
> > >
> > > Ok - I'm finally getting around to testing this patch.
> > >
> > > The driver will oops on this line because this routine is
> > > sometimes called when vdev=NULL. Your patch had removed the
> > > check for this NULL pointer. We probally should add it back.
> >
> > Do you have a backtrace of such a case? It really shouldn't happen
> > as the vdev is allocated in ->slave_alloc, and that one returns an
> > error if it couldn't allocate.
> >
>
>
> The problem is mptscsih_slave_destroy is being called twice. The first
> time we free hd->Targets, the second time we hit the oops. I'm still
> investigating. Here is back trace using source level debugger. Also
> beyond the back trace is snip of source, having the embedded printks.
the only thing I could imagine that could cause this is a race in
num_luns manipulation. Care to check whether the oops goes away when
you turn it into an atomic_t?
next prev parent reply other threads:[~2004-10-21 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 18:39 [PATCH] fusion: streamline ->slave_alloc/->slave_destroy Moore, Eric Dean
2004-10-21 9:09 ` Christoph Hellwig [this message]
2004-10-26 12:55 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2004-10-26 16:02 Moore, Eric Dean
2004-10-26 16:12 ` Christoph Hellwig
2004-10-06 18:25 Moore, Eric Dean
2004-10-09 14:51 ` Christoph Hellwig
2004-10-02 8:23 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041021090940.GC25645@lst.de \
--to=hch@lst.de \
--cc=Emoore@lsil.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).