From: Nishanth Aravamudan <nacc@us.ibm.com>
To: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
janitor@sternwelten.at,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [patch 08/10] scsi/dpt_i2o: replace schedule_timeout()withmsleep_interruptible()
Date: Fri, 22 Oct 2004 16:22:25 -0700 [thread overview]
Message-ID: <20041022232225.GA18906@us.ibm.com> (raw)
In-Reply-To: <60807403EABEB443939A5A7AA8A7458B40B611@otce2k01.adaptec.com>
On Thu, Oct 21, 2004 at 10:11:31AM -0400, Salyzyn, Mark wrote:
> I have to speak in absence of the original author, but I believe the
> decision to conditionalize the unlock was because this routine is called
> at init time and at run time.
>
> I did not notice the `stutter' of the two schedule_timeout's. Eeeeek!!!
> (My scientific replacement for bogus). Thanks for shaking the cobwebs.
>
> The second schedule_timeout needs to be *removed*, it does not belong
> there at all!
Please find below a patch which does exactly this.
Description: Removes a schedule_timeout() from adpt_i2o_post_wait() whch
Mark Salyzyn requested be removed.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-bk7-vanilla/drivers/scsi/dpt_i2o.c 2004-10-22 10:41:29.000000000 -0700
+++ 2.6.9-bk7/drivers/scsi/dpt_i2o.c 2004-10-22 15:22:53.000000000 -0700
@@ -1179,7 +1179,6 @@ static int adpt_i2o_post_wait(adpt_hba*
// dangerous.
status = -ETIME;
}
- schedule_timeout(timeout*HZ);
}
if(pHba->host)
spin_lock_irq(pHba->host->host_lock);
next prev parent reply other threads:[~2004-10-22 23:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 14:11 [patch 08/10] scsi/dpt_i2o: replace schedule_timeout()withmsleep_interruptible() Salyzyn, Mark
2004-10-22 23:22 ` Nishanth Aravamudan [this message]
2004-10-24 14:03 ` maximilian attems
2004-10-24 14:39 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2004-10-25 11:30 Salyzyn, Mark
2004-10-25 14:19 ` James Bottomley
2004-10-21 13:17 [patch 08/10] scsi/dpt_i2o: replace schedule_timeout() withmsleep_interruptible() Salyzyn, Mark
2004-10-21 13:47 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041022232225.GA18906@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=janitor@sternwelten.at \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).