From: mikem <mikem@beardog.cca.cpqcorp.net>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: marcelo.tosatti@cyclades.com, Jens Axboe <axboe@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [patch 1/2] cciss: cleans up warnings in the 32/64 bit conversions
Date: Tue, 26 Oct 2004 14:45:51 -0500 [thread overview]
Message-ID: <20041026194551.GA21003@beardog.cca.cpqcorp.net> (raw)
In-Reply-To: <1098633262.10824.35.camel@mulgrave>
On Sun, Oct 24, 2004 at 11:54:15AM -0400, James Bottomley wrote:
> On Thu, 2004-10-21 at 17:17, mike.miller@hp.com wrote:
> > Patch 1 of 2 for 20041021.
> > This patch cleans up some warnings in the 32-bit to 64-bit conversions.
> > Please consider this for inclusion. Built against 2.4.28-pre4.
> > Please apply in order.
>
> There's something wrong with this patch (it might be a missing prior
> patch) that's causing it to reject comprehensively.
>
> > -typedef long (*handler_type) (unsigned int, unsigned int, unsigned long,
> > +typedef int (*handler_type) (unsigned int, unsigned int, unsigned long,
>
> Things like this. handler_type has always been int not long in the
> source that's currently in the tree.
>
> James
>
Which tree are you applying to? This was made from 2.4.28-pre4.
mikem
>
next prev parent reply other threads:[~2004-10-26 19:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 21:17 [patch 1/2] cciss: cleans up warnings in the 32/64 bit conversions mike.miller
2004-10-22 0:00 ` Maciej W. Rozycki
2004-10-22 18:30 ` mikem
2004-10-22 20:59 ` Maciej W. Rozycki
2004-10-28 10:43 ` Marcelo Tosatti
2004-10-24 15:54 ` James Bottomley
2004-10-26 19:45 ` mikem [this message]
2004-10-26 19:57 ` James Bottomley
2004-10-26 21:44 ` mikem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041026194551.GA21003@beardog.cca.cpqcorp.net \
--to=mikem@beardog.cca.cpqcorp.net \
--cc=James.Bottomley@SteelEye.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox