* [PATCH] 3ware bad queuecommand returns
@ 2004-11-19 8:43 Jens Axboe
0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2004-11-19 8:43 UTC (permalink / raw)
To: linux-scsi, James Bottomley; +Cc: linuxraid, Linus Torvalds
Hi,
If your ->queuecommand() completes a command through done, it must not
return non-zero to the mid layer so that it takes ownership of the
command again.
Signed-off-by: Jens Axboe <axboe@suse.de>
===== drivers/scsi/3w-9xxx.c 1.4 vs edited =====
--- 1.4/drivers/scsi/3w-9xxx.c 2004-07-16 17:20:43 +02:00
+++ edited/drivers/scsi/3w-9xxx.c 2004-11-18 22:55:58 +01:00
@@ -1746,6 +1746,7 @@ static int twa_scsi_queue(struct scsi_cm
twa_free_request_id(tw_dev, request_id);
SCpnt->result = (DID_ERROR << 16);
done(SCpnt);
+ reval = 0;
}
return retval;
===== drivers/scsi/3w-xxxx.c 1.47 vs edited =====
--- 1.47/drivers/scsi/3w-xxxx.c 2004-10-07 05:20:16 +02:00
+++ edited/drivers/scsi/3w-xxxx.c 2004-11-18 22:55:31 +01:00
@@ -2067,6 +2067,7 @@ static int tw_scsi_queue(struct scsi_cmn
tw_state_request_finish(tw_dev, request_id);
SCpnt->result = (DID_ERROR << 16);
done(SCpnt);
+ retval = 0;
}
out:
return retval;
--
Jens Axboe
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-11-19 8:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-19 8:43 [PATCH] 3ware bad queuecommand returns Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).