From: Christoph Hellwig <hch@infradead.org>
To: Martin Peschke3 <MPESCHKE@de.ibm.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] retry HARDWARE ERROR for IBM ESS
Date: Fri, 19 Nov 2004 19:10:12 +0000 [thread overview]
Message-ID: <20041119191012.GB7936@infradead.org> (raw)
In-Reply-To: <OFEBA9F7AA.4CED279D-ONC1256F51.00512489-C1256F51.0062A4A4@de.ibm.com>
> + case HARDWARE_ERROR:
> + if ((strncmp(SCpnt->device->vendor, "IBM", 3) == 0) &&
> + (strncmp(SCpnt->device->model, "2105", 4) == 0))
> + return NEEDS_RETRY;
> + else
> + return SUCCESS;
> +
please don't hardcode models deep inside the scsu layer. Add a new
blacklist flags and set it from the table in scsi_devinfo.c
next prev parent reply other threads:[~2004-11-19 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 17:50 [PATCH] retry HARDWARE ERROR for IBM ESS Martin Peschke3
2004-11-19 19:10 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-12-10 21:15 Martin Peschke3
2004-12-11 5:36 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041119191012.GB7936@infradead.org \
--to=hch@infradead.org \
--cc=MPESCHKE@de.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox