Re: 2.6.10-rc2-mm2 usb storage still oopses

Re: 2.6.10-rc2-mm2 usb storage still oopses

[Pete Zaitcev]

On Fri, 19 Nov 2004 00:42:40 +0100, Fabio Coatti <cova@ferrara.linux.it> wrote:

> Nov 18 20:33:05 kefk kernel: sdb: assuming drive cache: write through
> Nov 18 20:33:05 kefk kernel:  sdb: sdb1
> Nov 18 20:33:05 kefk kernel:  sdb: sdb1
> Nov 18 20:33:05 kefk kernel: kobject_register failed for sdb1 (-17)

This looks as if SCSI falls victim of the general problem which ub addresses
with the following fragment:

--- linux-2.6.10-rc1/drivers/block/ub.c	2004-10-28 09:46:38.000000000 -0700
+++ linux-2.6.10-rc1-ub/drivers/block/ub.c	2004-11-06 23:59:20.000000000 -0800
@@ -267,6 +263,7 @@ struct ub_dev {
 	int changed;			/* Media was changed */
 	int removable;
 	int readonly;
+	int first_open;			/* Kludge. See ub_bd_open. */
 	char name[8];
 	struct usb_device *dev;
 	struct usb_interface *intf;
@@ -1428,6 +1420,26 @@ static int ub_bd_open(struct inode *inod
 	sc->openc++;
 	spin_unlock_irqrestore(&ub_lock, flags);
 
+	/*
+	 * This is a workaround for a specific problem in our block layer.
+	 * In 2.6.9, register_disk duplicates the code from rescan_partitions.
+	 * However, if we do add_disk with a device which persistently reports
+	 * a changed media, add_disk calls register_disk, which does do_open,
+	 * which will call rescan_paritions for changed media. After that,
+	 * register_disk attempts to do it all again and causes double kobject
+	 * registration and a eventually an oops on module removal.
+	 *
+	 * The bottom line is, Al Viro says that we should not allow
+	 * bdev->bd_invalidated to be set when doing add_disk no matter what.
+	 */
+	if (sc->first_open) {
+		if (sc->changed) {
+			sc->first_open = 0;
+			rc = -ENOMEDIUM;
+			goto err_open;
+		}
+	}
+
 	if (sc->removable || sc->readonly)
 		check_disk_change(inode->i_bdev);
 
@@ -1467,6 +1479,8 @@ static int ub_bd_release(struct inode *i
 
 	spin_lock_irqsave(&ub_lock, flags);
 	--sc->openc;
+	if (sc->openc == 0)
+		sc->first_open = 0;
 	if (sc->openc == 0 && atomic_read(&sc->poison))
 		ub_cleanup(sc);
 	spin_unlock_irqrestore(&ub_lock, flags);
@@ -1919,6 +1932,8 @@ static int ub_probe(struct usb_interface
 	}
 
 	sc->removable = 1;		/* XXX Query this from the device */
+	sc->changed = 1;		/* ub_revalidate clears only */
+	sc->first_open = 1;
 
 	ub_revalidate(sc);
 	/* This is pretty much a long term P3 */

This feels kludgy, but my excuse is "James and Viro made me do it".
I have an IRC log to prove it laying somewhere...

I'm adding the linux-scsi to cc: in case any comments are forthcoming.

-- Pete


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Re: 2.6.10-rc2-mm2 usb storage still oopses

[Andrew Morton]

Pete Zaitcev <zaitcev@redhat.com> wrote:
>
> On Fri, 19 Nov 2004 00:42:40 +0100, Fabio Coatti <cova@ferrara.linux.it> wrote:
> 
> > Nov 18 20:33:05 kefk kernel: sdb: assuming drive cache: write through
> > Nov 18 20:33:05 kefk kernel:  sdb: sdb1
> > Nov 18 20:33:05 kefk kernel:  sdb: sdb1
> > Nov 18 20:33:05 kefk kernel: kobject_register failed for sdb1 (-17)
> 
> This looks as if SCSI falls victim of the general problem which ub addresses
> with the following fragment:

Guys, is this problem still present in Linus's tree?  If so, is a fix for
2.6.10 looking feasible?

Thanks.

> --- linux-2.6.10-rc1/drivers/block/ub.c	2004-10-28 09:46:38.000000000 -0700
> +++ linux-2.6.10-rc1-ub/drivers/block/ub.c	2004-11-06 23:59:20.000000000 -0800
> @@ -267,6 +263,7 @@ struct ub_dev {
>  	int changed;			/* Media was changed */
>  	int removable;
>  	int readonly;
> +	int first_open;			/* Kludge. See ub_bd_open. */
>  	char name[8];
>  	struct usb_device *dev;
>  	struct usb_interface *intf;
> @@ -1428,6 +1420,26 @@ static int ub_bd_open(struct inode *inod
>  	sc->openc++;
>  	spin_unlock_irqrestore(&ub_lock, flags);
>  
> +	/*
> +	 * This is a workaround for a specific problem in our block layer.
> +	 * In 2.6.9, register_disk duplicates the code from rescan_partitions.
> +	 * However, if we do add_disk with a device which persistently reports
> +	 * a changed media, add_disk calls register_disk, which does do_open,
> +	 * which will call rescan_paritions for changed media. After that,
> +	 * register_disk attempts to do it all again and causes double kobject
> +	 * registration and a eventually an oops on module removal.
> +	 *
> +	 * The bottom line is, Al Viro says that we should not allow
> +	 * bdev->bd_invalidated to be set when doing add_disk no matter what.
> +	 */
> +	if (sc->first_open) {
> +		if (sc->changed) {
> +			sc->first_open = 0;
> +			rc = -ENOMEDIUM;
> +			goto err_open;
> +		}
> +	}
> +
>  	if (sc->removable || sc->readonly)
>  		check_disk_change(inode->i_bdev);
>  
> @@ -1467,6 +1479,8 @@ static int ub_bd_release(struct inode *i
>  
>  	spin_lock_irqsave(&ub_lock, flags);
>  	--sc->openc;
> +	if (sc->openc == 0)
> +		sc->first_open = 0;
>  	if (sc->openc == 0 && atomic_read(&sc->poison))
>  		ub_cleanup(sc);
>  	spin_unlock_irqrestore(&ub_lock, flags);
> @@ -1919,6 +1932,8 @@ static int ub_probe(struct usb_interface
>  	}
>  
>  	sc->removable = 1;		/* XXX Query this from the device */
> +	sc->changed = 1;		/* ub_revalidate clears only */
> +	sc->first_open = 1;
>  
>  	ub_revalidate(sc);
>  	/* This is pretty much a long term P3 */
> 
> This feels kludgy, but my excuse is "James and Viro made me do it".
> I have an IRC log to prove it laying somewhere...
> 
> I'm adding the linux-scsi to cc: in case any comments are forthcoming.
> 
> -- Pete


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Re: 2.6.10-rc2-mm2 usb storage still oopses

[James Bottomley]

On Mon, 2004-11-29 at 18:32, Andrew Morton wrote:
> Pete Zaitcev <zaitcev@redhat.com> wrote:
> >
> > On Fri, 19 Nov 2004 00:42:40 +0100, Fabio Coatti <cova@ferrara.linux.it> wrote:
> > 
> > > Nov 18 20:33:05 kefk kernel: sdb: assuming drive cache: write through
> > > Nov 18 20:33:05 kefk kernel:  sdb: sdb1
> > > Nov 18 20:33:05 kefk kernel:  sdb: sdb1
> > > Nov 18 20:33:05 kefk kernel: kobject_register failed for sdb1 (-17)
> > 
> > This looks as if SCSI falls victim of the general problem which ub addresses
> > with the following fragment:
> 
> Guys, is this problem still present in Linus's tree?  If so, is a fix for
> 2.6.10 looking feasible?

Al Viro has a tentative one at

http://ftp.linux.org.uk/pub/people/viro/register_disk-hack

If someone could try it out and verify that it fixes the problem, we
could put it in.

James

Re: 2.6.10-rc2-mm2 usb storage still oopses

[Fabio Coatti]

Alle 04:22, martedì 30 novembre 2004, James Bottomley ha scritto:


> > >
> > > This looks as if SCSI falls victim of the general problem which ub
> > > addresses with the following fragment:
> >
> > Guys, is this problem still present in Linus's tree?  If so, is a fix for
> > 2.6.10 looking feasible?
>
> Al Viro has a tentative one at
>
> http://ftp.linux.org.uk/pub/people/viro/register_disk-hack
>
> If someone could try it out and verify that it fixes the problem, we
> could put it in.


Now I'm at work; this evening I'll try and I'll report asap the results. on 
wich kernel does it apply? last kernels that I've tried are 2.6.10-rcX-mmY 
series, but I can try the most suitable version for debugging, just let me 
know.



-- 
Fabio "Cova" Coatti    http://members.ferrara.linux.it/cova     
Ferrara Linux Users Group           http://ferrara.linux.it
GnuPG fp:9765 A5B6 6843 17BC A646  BE8C FA56 373A 5374 C703
Old SysOps never die... they simply forget their password.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: 2.6.10-rc2-mm2 usb storage still oopses

[Fabio Coatti]

Alle 04:22, martedì 30 novembre 2004, James Bottomley ha scritto:

> >
> > Guys, is this problem still present in Linus's tree?  If so, is a fix for
> > 2.6.10 looking feasible?
>
> Al Viro has a tentative one at
>
> http://ftp.linux.org.uk/pub/people/viro/register_disk-hack
>
> If someone could try it out and verify that it fixes the problem, we
> could put it in.

OK, here the result for tests, using 2.6.10-rc2-mm4.
I've to put a 
options usbcore old_scheme_first=1
in modprobe.conf, otherwise the device is not detected.
With this option set, all works just fine (no ub module compiled or loaded, if 
needed I can try also with this): no oopses, no call trace, it just works :)

The only small issue is that if i leave plugged the usb flash key and 
power-cycle my box, at boot the device is not detected and it fails in the 
same way it happens when usbcore old_scheme_first is not set (it's present in 
modprobe.conf)

If I unplug/plug the device, all works just fine.

Great work !

Full logs:

Inserting the device with usbcore old_scheme_first=1:

Nov 30 19:54:41 kefk kernel: hub 5-0:1.0: state 5 ports 8 chg ff00 evt 0008
Nov 30 19:54:41 kefk kernel: ehci_hcd 0000:00:1d.7: GetStatus port 3 status 
001803 POWER sig=j  CSC CONNECT
Nov 30 19:54:41 kefk kernel: hub 5-0:1.0: port 3, status 0501, change 0001, 
480 Mb/s
Nov 30 19:54:41 kefk kernel: hub 5-0:1.0: debounce: port 3: total 100ms stable 
100ms status 0x501
Nov 30 19:54:41 kefk kernel: ehci_hcd 0000:00:1d.7: port 3 high speed
Nov 30 19:54:41 kefk kernel: ehci_hcd 0000:00:1d.7: GetStatus port 3 status 
001005 POWER sig=se0  PE CONNECT
Nov 30 19:54:41 kefk kernel: usb 5-3: new high speed USB device using ehci_hcd 
and address 3
Nov 30 19:54:41 kefk kernel: usb 5-3: new device strings: Mfr=1, Product=2, 
SerialNumber=3
Nov 30 19:54:41 kefk kernel: usb 5-3: default language 0x0409
Nov 30 19:54:41 kefk kernel: usb 5-3: Product: Mass storage
Nov 30 19:54:41 kefk kernel: usb 5-3: Manufacturer: USB
Nov 30 19:54:41 kefk kernel: usb 5-3: SerialNumber: 142E19413C2FCA34
Nov 30 19:54:41 kefk kernel: usb 5-3: hotplug
Nov 30 19:54:41 kefk kernel: usb 5-3: adding 5-3:1.0 (config #1, interface 0)
Nov 30 19:54:41 kefk kernel: usb 5-3:1.0: hotplug
Nov 30 19:54:42 kefk kernel: Initializing USB Mass Storage driver...
Nov 30 19:54:42 kefk kernel: usb-storage 5-3:1.0: usb_probe_interface
Nov 30 19:54:42 kefk kernel: usb-storage 5-3:1.0: usb_probe_interface - got id
Nov 30 19:54:42 kefk kernel: scsi3 : SCSI emulation for USB Mass Storage 
devices
Nov 30 19:54:42 kefk kernel: usbcore: registered new driver usb-storage
Nov 30 19:54:42 kefk kernel: USB Mass Storage support registered.
Nov 30 19:54:42 kefk kernel: usb-storage: device found at 3
Nov 30 19:54:42 kefk kernel: usb-storage: waiting for device to settle before 
scanning
Nov 30 19:54:47 kefk kernel:   Vendor: 512MB     Model: USB2.0FlashDrive  Rev: 
2.00
Nov 30 19:54:47 kefk kernel:   Type:   Direct-Access                      ANSI 
SCSI revision: 02
Nov 30 19:54:47 kefk kernel: sdb: Unit Not Ready, sense:
Nov 30 19:54:47 kefk kernel: : Current: sense key=0x6
Nov 30 19:54:47 kefk kernel:     ASC=0x28 ASCQ=0x0
Nov 30 19:54:47 kefk kernel: sdb : READ CAPACITY failed.
Nov 30 19:54:47 kefk kernel: sdb : status=1, message=00, host=0, driver=08
Nov 30 19:54:47 kefk kernel: sd: Current: sense key=0x6
Nov 30 19:54:47 kefk kernel:     ASC=0x28 ASCQ=0x0
Nov 30 19:54:47 kefk kernel: sdb: test WP failed, assume Write Enabled
Nov 30 19:54:47 kefk kernel: sdb: assuming drive cache: write through
Nov 30 19:54:47 kefk kernel: sdb: Unit Not Ready, sense:
Nov 30 19:54:47 kefk kernel: : Current: sense key=0x6
Nov 30 19:54:47 kefk kernel:     ASC=0x28 ASCQ=0x0
Nov 30 19:54:47 kefk kernel: SCSI device sdb: 1024000 512-byte hdwr sectors 
(524 MB)
Nov 30 19:54:47 kefk kernel: sdb: Write Protect is off
Nov 30 19:54:47 kefk kernel: sdb: Mode Sense: 03 00 00 00
Nov 30 19:54:47 kefk kernel: sdb: assuming drive cache: write through
Nov 30 19:54:47 kefk kernel: SCSI device sdb: 1024000 512-byte hdwr sectors 
(524 MB)
Nov 30 19:54:47 kefk kernel: sdb: Write Protect is off
Nov 30 19:54:47 kefk kernel: sdb: Mode Sense: 03 00 00 00
Nov 30 19:54:47 kefk kernel: sdb: assuming drive cache: write through
Nov 30 19:54:47 kefk kernel:  sdb: sdb1
Nov 30 19:54:47 kefk kernel: Attached scsi removable disk sdb at scsi3, 
channel 0, id 0, lun 0
Nov 30 19:54:47 kefk kernel: Attached scsi generic sg4 at scsi3, channel 0, id 
0, lun 0,  type 0
Nov 30 19:54:47 kefk kernel: usb-storage: device scan complete
Nov 30 19:54:47 kefk scsi.agent[7714]: disk 
at /devices/pci0000:00/0000:00:1d.7/usb5/5-3/5-3:1.0/host3/target3:0:0/3:0:0:0


removing it:
Nov 30 19:55:44 kefk kernel: hub 5-0:1.0: state 5 ports 8 chg ff00 evt 0008
Nov 30 19:55:44 kefk kernel: ehci_hcd 0000:00:1d.7: GetStatus port 3 status 
001002 POWER sig=se0  CSC
Nov 30 19:55:44 kefk kernel: hub 5-0:1.0: port 3, status 0100, change 0001, 12 
Mb/s
Nov 30 19:55:44 kefk kernel: usb 5-3: USB disconnect, address 3
Nov 30 19:55:44 kefk kernel: usb 5-3: usb_disable_device nuking all URBs
Nov 30 19:55:44 kefk kernel: usb 5-3: unregistering interface 5-3:1.0
Nov 30 19:55:44 kefk kernel: usb 5-3:1.0: hotplug
Nov 30 19:55:44 kefk kernel: usb 5-3: unregistering device
Nov 30 19:55:44 kefk kernel: usb 5-3: hotplug
Nov 30 19:55:44 kefk kernel: hub 5-0:1.0: debounce: port 3: total 100ms stable 
100ms status 0x100


inserting the device with old_scheme_first not set:

Nov 30 20:00:25 kefk kernel: hub 5-0:1.0: state 5 ports 8 chg ff00 evt 0008
Nov 30 20:00:25 kefk kernel: ehci_hcd 0000:00:1d.7: GetStatus port 3 status 
001803 POWER sig=j  CSC CONNECT
Nov 30 20:00:25 kefk kernel: hub 5-0:1.0: port 3, status 0501, change 0001, 
480 Mb/s
Nov 30 20:00:25 kefk kernel: hub 5-0:1.0: debounce: port 3: total 100ms stable 
100ms status 0x501
Nov 30 20:00:25 kefk kernel: ehci_hcd 0000:00:1d.7: port 3 high speed
Nov 30 20:00:25 kefk kernel: ehci_hcd 0000:00:1d.7: GetStatus port 3 status 
001005 POWER sig=se0  PE CONNECT
Nov 30 20:00:25 kefk kernel: usb 5-3: new high speed USB device using ehci_hcd 
and address 3
Nov 30 20:00:25 kefk kernel: ehci_hcd 0000:00:1d.7: devpath 3 ep0in 3strikes
Nov 30 20:00:25 kefk kernel: ehci_hcd 0000:00:1d.7: port 3 full speed --> 
companion
Nov 30 20:00:25 kefk kernel: ehci_hcd 0000:00:1d.7: GetStatus port 3 status 
003801 POWER OWNER sig=j  CONNECT
Nov 30 20:00:25 kefk kernel: uhci_hcd 0000:00:1d.1: wakeup_hc
Nov 30 20:00:26 kefk kernel: hub 2-0:1.0: state 5 ports 2 chg fffc evt 0002
Nov 30 20:00:26 kefk kernel: uhci_hcd 0000:00:1d.1: port 1 portsc 0083,00
Nov 30 20:00:26 kefk kernel: hub 2-0:1.0: port 1, status 0101, change 0001, 12 
Mb/s
Nov 30 20:00:26 kefk kernel: hub 2-0:1.0: debounce: port 1: total 100ms stable 
100ms status 0x101
Nov 30 20:00:26 kefk kernel: usb 2-1: new full speed USB device using uhci_hcd 
and address 2
Nov 30 20:00:26 kefk kernel: uhci_hcd 0000:00:1d.1: uhci_result_control: 
failed with status 440000
Nov 30 20:00:26 kefk kernel: [f7977240] link (379771b2) element (37a86040)
Nov 30 20:00:26 kefk kernel:   0: [f7a86040] link (37a86080) e0 Stalled 
CRC/Timeo Length=7 MaxLen=7 DT0 EndPt=0 Dev=0, PID=2d(SETUP) (buf=37144ba0)
Nov 30 20:00:26 kefk kernel:   1: [f7a86080] link (37a860c0) e3 SPD Active 
Length=0 MaxLen=3f DT1 EndPt=0 Dev=0, PID=69(IN) (buf=355ae500)
Nov 30 20:00:26 kefk kernel:   2: [f7a860c0] link (00000001) e3 IOC Active 
Length=0 MaxLen=7ff DT1 EndPt=0 Dev=0, PID=e1(OUT) (buf=00000000)
Nov 30 20:00:26 kefk kernel:
Nov 30 20:00:26 kefk kernel: usb 2-1: device descriptor read/64, error -71
Nov 30 20:00:26 kefk kernel: uhci_hcd 0000:00:1d.1: uhci_result_control: 
failed with status 440000
Nov 30 20:00:26 kefk kernel: [f7977240] link (379771b2) element (37a86040)
Nov 30 20:00:26 kefk kernel:   0: [f7a86040] link (37a86080) e0 Stalled 
CRC/Timeo Length=7 MaxLen=7 DT0 EndPt=0 Dev=0, PID=2d(SETUP) (buf=36486e60)
Nov 30 20:00:26 kefk kernel:   1: [f7a86080] link (37a860c0) e3 SPD Active 
Length=0 MaxLen=3f DT1 EndPt=0 Dev=0, PID=69(IN) (buf=355aef00)
Nov 30 20:00:26 kefk kernel:   2: [f7a860c0] link (00000001) e3 IOC Active 
Length=0 MaxLen=7ff DT1 EndPt=0 Dev=0, PID=e1(OUT) (buf=00000000)

Now, rebooting the box leaving the device inserted, with old_scheme_first=1 in 
modprobe.conf

Nov 30 20:03:40 kefk kernel: usb 4-0:1.0: hotplug
Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: usb_probe_interface
Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: usb_probe_interface - got id
Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: USB hub found
Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: 2 ports detected
Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: standalone hub
Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: no power switching (usb 1.0)
Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: individual port over-current 
protection
Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: power on to power good time: 2ms
Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: local power source is good
Nov 30 20:03:40 kefk kernel: hub 2-0:1.0: debounce: port 1: total 100ms stable 
100ms status 0x101
Nov 30 20:03:40 kefk kernel: usb 2-1: new full speed USB device using uhci_hcd 
and address 2
Nov 30 20:03:40 kefk kernel: uhci_hcd 0000:00:1d.1: uhci_result_control: 
failed with status 440000
Nov 30 20:03:40 kefk kernel: [f7ab5240] link (37ab51b2) element (37ab4040)
Nov 30 20:03:40 kefk kernel:   0: [f7ab4040] link (37ab4080) e0 Stalled 
CRC/Timeo Length=7 MaxLen=7 DT0 EndPt=0 Dev=0, PID=2d(SETUP) (buf=37998f20)
Nov 30 20:03:40 kefk kernel:   1: [f7ab4080] link (00000001) e3 IOC Active 
Length=0 MaxLen=7ff DT1 EndPt=0 Dev=0, PID=69(IN) (buf=00000000)
Nov 30 20:03:40 kefk kernel:
Nov 30 20:03:40 kefk kernel: uhci_hcd 0000:00:1d.1: uhci_result_control: 
failed with status 440000
Nov 30 20:03:40 kefk kernel: [f7ab5240] link (37ab51b2) element (37ab4040)
Nov 30 20:03:40 kefk kernel:   0: [f7ab4040] link (37ab4080) e0 Stalled 
CRC/Timeo Length=7 MaxLen=7 DT0 EndPt=0 Dev=0, PID=2d(SETUP) (buf=378ef180)
Nov 30 20:03:40 kefk kernel:   1: [f7ab4080] link (00000001) e3 IOC Active 
Length=0 MaxLen=7ff DT1 EndPt=0 Dev=0, PID=69(IN) (buf=00000000)
Nov 30 20:03:40 kefk kernel:
Nov 30 20:03:40 kefk kernel: usb 2-1: device not accepting address 2, error 
-71
Nov 30 20:03:40 kefk kernel: usb 2-1: new full speed USB device using uhci_hcd 
and address 3
Nov 30 20:03:40 kefk kernel: uhci_hcd 0000:00:1d.1: uhci_result_control: 
failed with status 440000
Nov 30 20:03:40 kefk kernel: [f7ab5240] link (37ab51b2) element (37ab4040)
Nov 30 20:03:40 kefk kernel:   0: [f7ab4040] link (37ab4080) e0 Stalled 
CRC/Timeo Length=7 MaxLen=7 DT0 EndPt=0 Dev=0, PID=2d(SETUP) (buf=378ef180)
Nov 30 20:03:40 kefk kernel:   1: [f7ab4080] link (00000001) e3 IOC Active 
Length=0 MaxLen=7ff DT1 EndPt=0 Dev=0, PID=69(IN) (buf=00000000)

After this, if I remove and plug again the device, all works just fine.







-- 
Fabio Coatti       http://members.ferrara.linux.it/cova     
Ferrara Linux Users Group           http://ferrara.linux.it
GnuPG fp:9765 A5B6 6843 17BC A646  BE8C FA56 373A 5374 C703
Old SysOps never die... they simply forget their password.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Re: Re: 2.6.10-rc2-mm2 usb storage still oopses

[Alan Stern]

On Tue, 30 Nov 2004, Fabio Coatti wrote:

> The only small issue is that if i leave plugged the usb flash key and 
> power-cycle my box, at boot the device is not detected and it fails in the 
> same way it happens when usbcore old_scheme_first is not set (it's present in 
> modprobe.conf)
> 
> If I unplug/plug the device, all works just fine.

> Now, rebooting the box leaving the device inserted, with old_scheme_first=1 in 
> modprobe.conf
> 
> Nov 30 20:03:40 kefk kernel: usb 4-0:1.0: hotplug
> Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: usb_probe_interface
> Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: usb_probe_interface - got id
> Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: USB hub found
> Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: 2 ports detected
> Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: standalone hub
> Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: no power switching (usb 1.0)
> Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: individual port over-current 
> protection
> Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: power on to power good time: 2ms
> Nov 30 20:03:40 kefk kernel: hub 4-0:1.0: local power source is good
> Nov 30 20:03:40 kefk kernel: hub 2-0:1.0: debounce: port 1: total 100ms stable 
> 100ms status 0x101
> Nov 30 20:03:40 kefk kernel: usb 2-1: new full speed USB device using uhci_hcd 
> and address 2
> Nov 30 20:03:40 kefk kernel: uhci_hcd 0000:00:1d.1: uhci_result_control: 
> failed with status 440000
> Nov 30 20:03:40 kefk kernel: [f7ab5240] link (37ab51b2) element (37ab4040)
> Nov 30 20:03:40 kefk kernel:   0: [f7ab4040] link (37ab4080) e0 Stalled 
> CRC/Timeo Length=7 MaxLen=7 DT0 EndPt=0 Dev=0, PID=2d(SETUP) (buf=37998f20)
> Nov 30 20:03:40 kefk kernel:   1: [f7ab4080] link (00000001) e3 IOC Active 
> Length=0 MaxLen=7ff DT1 EndPt=0 Dev=0, PID=69(IN) (buf=00000000)
> Nov 30 20:03:40 kefk kernel:
> Nov 30 20:03:40 kefk kernel: uhci_hcd 0000:00:1d.1: uhci_result_control: 
> failed with status 440000
> Nov 30 20:03:40 kefk kernel: [f7ab5240] link (37ab51b2) element (37ab4040)
> Nov 30 20:03:40 kefk kernel:   0: [f7ab4040] link (37ab4080) e0 Stalled 
> CRC/Timeo Length=7 MaxLen=7 DT0 EndPt=0 Dev=0, PID=2d(SETUP) (buf=378ef180)
> Nov 30 20:03:40 kefk kernel:   1: [f7ab4080] link (00000001) e3 IOC Active 
> Length=0 MaxLen=7ff DT1 EndPt=0 Dev=0, PID=69(IN) (buf=00000000)
> Nov 30 20:03:40 kefk kernel:
> Nov 30 20:03:40 kefk kernel: usb 2-1: device not accepting address 2, error 
> -71
> Nov 30 20:03:40 kefk kernel: usb 2-1: new full speed USB device using uhci_hcd 
> and address 3
> Nov 30 20:03:40 kefk kernel: uhci_hcd 0000:00:1d.1: uhci_result_control: 
> failed with status 440000
> Nov 30 20:03:40 kefk kernel: [f7ab5240] link (37ab51b2) element (37ab4040)
> Nov 30 20:03:40 kefk kernel:   0: [f7ab4040] link (37ab4080) e0 Stalled 
> CRC/Timeo Length=7 MaxLen=7 DT0 EndPt=0 Dev=0, PID=2d(SETUP) (buf=378ef180)
> Nov 30 20:03:40 kefk kernel:   1: [f7ab4080] link (00000001) e3 IOC Active 
> Length=0 MaxLen=7ff DT1 EndPt=0 Dev=0, PID=69(IN) (buf=00000000)
> 
> After this, if I remove and plug again the device, all works just fine.

This log shows that the device was operating at full speed, not at high 
speed.  Probably your boot-up sequence involves loading the uhci-hcd 
driver before ehci-hcd.

It may be that the device wants old_scheme_first to be set when it's 
operating at high speed and not set when operating at full speed!  You can 
test this guess by unloading one driver or the other and then plugging in 
the device.

Alan Stern



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Re: Re: 2.6.10-rc2-mm2 usb storage still oopses

[Fabio Coatti]

Alle 21:58, martedì 30 novembre 2004, Alan Stern ha scritto:

> It may be that the device wants old_scheme_first to be set when it's
> operating at high speed and not set when operating at full speed!  You can
> test this guess by unloading one driver or the other and then plugging in
> the device.

Well, I've tried and in fact without 
old_scheme_first set ehci hands over the device to uhci, that fails to detect 
it.
And in fact uhci is loaded at boot before ehci. I've modified this, but the 
behaviour is not ok: it seems that the device is detected ok even if already 
present at boot, but then I've a keyoboard/mouse lockup

Dec  1 01:40:26 kefk kernel: ehci_hcd 0000:00:1d.7: port 3 high speed
Dec  1 01:40:26 kefk kernel: ehci_hcd 0000:00:1d.7: GetStatus port 3 status 
001005 POWER sig=se0  PE CONNECT
Dec  1 01:40:26 kefk kernel: usb 1-3: new high speed USB device using ehci_hcd 
and address 3
Dec  1 01:40:26 kefk kernel: usb 1-3: new device strings: Mfr=1, Product=2, 
SerialNumber=3
Dec  1 01:40:26 kefk kernel: usb 1-3: default language 0x0409
Dec  1 01:40:26 kefk kernel: usb 1-3: Product: Mass storage
Dec  1 01:40:26 kefk kernel: usb 1-3: Manufacturer: USB
Dec  1 01:40:26 kefk kernel: usb 1-3: SerialNumber: 142E19413C2FCA34
Dec  1 01:40:26 kefk kernel: usb 1-3: hotplug
Dec  1 01:40:26 kefk kernel: PCI: Setting latency timer of device 0000:00:1d.2 
to 64
Dec  1 01:40:26 kefk kernel: uhci_hcd 0000:00:1d.2: irq 169, io base 0xb400
Dec  1 01:40:26 kefk kernel: usb 1-3: adding 1-3:1.0 (config #1, interface 0)
Dec  1 01:40:26 kefk kernel: usb 1-3:1.0: hotplug


when cupds starts, that uses usb printer, the keyboard and mouse gets locked, 
simply no key press or mouse move are detected. (or, at least, it seems that 
cups driver loading causes the lockup, but I can try to repeat this).
the first log row after cups loading is this:
Dec  1 01:40:30 kefk kernel: ACPI: PCI interrupt 0000:03:04.0[A] -> GSI 20 
(level, low) -> IRQ 209

But I don't think taht this can be so useful.
Please let me know is different details are needed.


This happens only when ehci is loaded before uhci and flash key is present at 
boot. 
If I keep unplugged the flash key the boot sequence goes on without problem, 
then I can plug and use flash key.

I'm unable to see on the logs where something goes wrong, but if you can tell 
me if more data are needed I can cut&paste the logs.



-- 
Fabio Coatti       http://members.ferrara.linux.it/cova     
Ferrara Linux Users Group           http://ferrara.linux.it
GnuPG fp:9765 A5B6 6843 17BC A646  BE8C FA56 373A 5374 C703
Old SysOps never die... they simply forget their password.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel