linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Brian King <brking@us.ibm.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: drivers/block/scsi_ioctl problem
Date: Wed, 15 Dec 2004 08:18:53 +0100	[thread overview]
Message-ID: <20041215071852.GM3157@suse.de> (raw)
In-Reply-To: <41BF7C18.9090303@us.ibm.com>

On Tue, Dec 14 2004, Brian King wrote:
> Can someone explain to me the need for this bit of code in 
> drivers/block/scsi_ioctl.c:
> 
> if (!(type & CMD_WARNED)) {
> 	cmd_type[cmd[0]] = CMD_WARNED;
> 	printk(KERN_WARNING "scsi: unknown opcode 0x%02x\n", cmd[0]);
> }
> 
> I'm trying to convert an application to use SG_IO to /dev/sd* devices 
> rather than using /dev/sg* devices and this is one problem I have been 
> running into. Any time I issue a vendor specific scsi opcode I end up 
> getting one of these error logs. Is there a good reason this error log 
> is needed?

It was added to be able to find out which opcode was rejected and thus
caused an application malfunction. It dumps the specific opcode only
once, is that such a huge problem?

-- 
Jens Axboe


  parent reply	other threads:[~2004-12-15  7:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-14 23:49 drivers/block/scsi_ioctl problem Brian King
2004-12-15  5:32 ` Douglas Gilbert
2004-12-15  7:18 ` Jens Axboe [this message]
2004-12-15 19:13   ` Brian King
2004-12-15 22:44     ` Brian King
2004-12-16  6:32       ` Jens Axboe
2004-12-16 16:31         ` Brian King
2005-10-07 14:13         ` Brian King
2005-10-07 17:41           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041215071852.GM3157@suse.de \
    --to=axboe@suse.de \
    --cc=brking@us.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).