From: Tomas Henzl <thenzl@redhat.com>
To: Sumit Saxena <sumit.saxena@broadcom.com>, linux-scsi@vger.kernel.org
Cc: martin.petersen@oracle.com, Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] mpi3mr: rework mrioc->bsg_device model to fix up smatch warnings
Date: Mon, 30 May 2022 01:03:56 +0200 [thread overview]
Message-ID: <2004629b-4da6-8499-ea3f-709468178b42@redhat.com> (raw)
In-Reply-To: <20220526170157.58274-1-sumit.saxena@broadcom.com>
On 5/26/22 19:01, Sumit Saxena wrote:
> During driver unload, "mrioc->bsg_device" reference count becomes negative.
> Also, as reported in [1], driver's bsg_device model had few more
> bugs so reworked it to fix up them.
>
> [1] https://marc.info/?l=linux-scsi&m=165183971411991&w=2
>
> Fixes: 4268fa751365 ("scsi: mpi3mr: Add bsg device support")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
I've been seeing the issue when rmmod the driver, with this patch it's gone.
Tested-by: Tomas Henzl <thenzl@redhat.com>
next prev parent reply other threads:[~2022-05-29 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 17:01 [PATCH] mpi3mr: rework mrioc->bsg_device model to fix up smatch warnings Sumit Saxena
2022-05-29 23:03 ` Tomas Henzl [this message]
2022-06-02 2:23 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2004629b-4da6-8499-ea3f-709468178b42@redhat.com \
--to=thenzl@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox