From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: achim_leubner@adaptec.com,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] fix gcc warning on 64 bit compile of gdth
Date: Mon, 3 Jan 2005 22:54:01 +0000 [thread overview]
Message-ID: <20050103225401.GZ26051@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1104792580.5506.69.camel@mulgrave>
On Mon, Jan 03, 2005 at 04:49:39PM -0600, James Bottomley wrote:
> On Mon, 2005-01-03 at 22:43 +0000, Al Viro wrote:
> > *UGH*
> >
> > Why do you play with shoving dma_addr_t into a pair of pointers and
> > then decoding it when you have ->SCp.dma_handle?
>
> Well, I don't since it's not my driver.
>
> However, I think the nutcase it's trying to crack is storing dma_addr_t
> on x86 PAE. There dma_addr_t is wider than a void *.
... and dma_handle *is* dma_addr_t and gets used in exact same driver to
store the results of the same function (grep for pci_map_page in there).
next prev parent reply other threads:[~2005-01-03 22:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-03 21:45 [PATCH] fix gcc warning on 64 bit compile of gdth James Bottomley
2005-01-03 22:43 ` Al Viro
2005-01-03 22:49 ` James Bottomley
2005-01-03 22:54 ` Al Viro [this message]
2005-01-03 23:53 ` James Bottomley
2005-01-04 4:52 ` Al Viro
2005-01-04 8:27 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2005-01-04 9:29 Leubner, Achim
2005-01-04 9:32 ` Arjan van de Ven
2005-01-04 10:29 ` Al Viro
2005-01-05 11:19 ` Christoph Hellwig
2005-01-04 14:55 ` James Bottomley
2005-01-05 11:19 ` Christoph Hellwig
2005-01-04 10:57 Leubner, Achim
2005-01-04 11:53 ` Al Viro
2005-01-04 12:08 Leubner, Achim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050103225401.GZ26051@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=James.Bottomley@SteelEye.com \
--cc=achim_leubner@adaptec.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox