Re: Fw: ACARD SCSI driver update for Linux kernel v2.6

jameshsu
2005-01-14T09:59:56Z

[-- Attachment #1: Type: text/plain, Size: 3495 bytes --]

Hi all,

We, Acard, total understand what you suggest. (including advise from
Christoph, James B. and Alan.)
Therefore, we modify the internal code to create this patch file from kernel
v2.6.10.
However, as you see this is the smallest patch files which could be
generated. (Sorry, unable to meet your expetation)
The reason is : this driver could supports ATP870 as well as mutiples of
Acard's chipsets. (this includes ATP880(AEC67160) & ATP885(AEC67162)). This
is why the patch files is huge than what you expected.
We did not make any change for ATP870(AEC6712) on this rev.. Besides, we
reverse following codes according to all of your suggestions. Please review
and let me know if this is feasible. Welcome to any of question you may
have.
Thanks for your help!

Best regards,

Manager,Engineering Testing Dept.
ACARD TECHNOLOGY CORP.
Taipei Hsien,Taiwan
6F No78,Sec 1,Kwang Fu Road,Sang Chung,
(02)8512-2290 x 2311(O),(02)8512-1524(FAX)

----- Original Message -----
From: "jameshsu" <jameshsu@mail.acard.com>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: <linux-scsi@vger.kernel.org>; <James.Bottomley@SteelEye.com>;
"EdwardLian" <edwardlian@mail.acard.com>; "Jason Wu" <jason_wu@acard.com>
Sent: Friday, January 07, 2005 6:05 PM
Subject: Re: Fw: ACARD SCSI driver update for Linux kernel v2.6

> Hi Alan,
>
> We are in the process to modify the driver in order to meet your suggests.
> Following change has been made.
> 1) Put it back for originator's copyrights to the file.
> 2) Go back to build up/modify driver from kernel 2.6.10. according to
James
> Bottomley's suggestions
> 3) use new header
> <scsi/scsi.h>
> <scsi/scsi_host.h>
> <scsi/scsi_device.h>
> <scsi/scsi_cmnd.h>)
> 4) enable .max_sectors = 128
> 5) Either modify or remove all following declare:
> +#if LINUX_VERSION_CODE > KERNEL_VERSION(2,5,0)
> +static irqreturn_t atp885_intr_handle(int irq, void *dev_id, struct
> pt_regs *regs)
> +#else
> +static void atp885_intr_handle(int irq, void *dev_id, struct pt_regs
> *regs)
> +#endif
>
> +static struct Scsi_Host *atp_host[MAX_ADAPTER];
> +static int host_index = 0;
>
> 6) Reversals of some of improvements like hotplug pci made outside -
> Addition of support for the AEC67160Acard
> 7) more.....
> New driver will be submit around 1-2 week later.
> During these period, if you have more suggestions, please let us know ASAP
> while testing.
> Again, Thanks for your help!
>
> James Hsu,
> Manager,Engineering Testing Dept.
> ACARD TECHNOLOGY CORP.
> Taipei Hsien,Taiwan
> 6F No78,Sec 1,Kwang Fu Road,Sang Chung,
> (02)8512-2290 x 2311(O),(02)8512-1524(FAX)
>
>
> ----- Original Message -----
> From: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
> To: "jameshsu" <jameshsu@mail.acard.com>
> Cc: <linux-scsi@vger.kernel.org>
> Sent: Friday, January 07, 2005 7:10 AM
> Subject: Re: Fw: ACARD SCSI driver update for Linux kernel v2.6
>
>
> > The trouble with the patch as is, is that it mixes up
> >
> > - Reversals of improvements like hotplug pci made outside Acard
> > - Addition of support for the AEC67160
> > - Other unknown improvements Acard may have made
> >
> > In order for this to be useful we need to be able to see just the
> > changes that are important.
> >
> > I can easily see for example the new PCI identifiers but not the other
> > needed changes. In order to do that I really need either a description
> > of the relevant changes or those changes versus the existing 2.6 driver
> > tree.
> >
> > Any help welcomed.
> >
> > Alan
> >
>

[-- Attachment #2: Re_ Fw_ ACARD SCSI driver update for Linux kernel v2.6.eml --]
[-- Type: message/rfc822, Size: 2028 bytes --]

From: Christoph Hellwig <hch@infradead.org>
To: jameshsu <jameshsu@mail.acard.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-scsi@vger.kernel.org, James.Bottomley@SteelEye.com, EdwardLian <edwardlian@mail.acard.com>, Jason Wu <jason_wu@acard.com>
Subject: Re: Fw: ACARD SCSI driver update for Linux kernel v2.6
Date: Fri, 7 Jan 2005 10:11:44 +0000
Message-ID: <20050107101144.GA6094@infradead.org>

> New driver will be submit around 1-2 week later.
> During these period, if you have more suggestions, please let us know ASAP
> while testing.

In general life for us and you is easier if you submit changes as you
make them in small chunks. E.g. submit the new PCI ID asap, submit
small fixes you think are needed in the driver ASAP, etc..

Small patches are much easier review, and and you get obviously correct
pieces out ASAP.

[-- Attachment #3: atp870u-new-patch.tgz --]
[-- Type: application/octet-stream, Size: 18493 bytes --]

[-- Attachment #4: Change_histry.txt --]
[-- Type: text/plain, Size: 375 bytes --]

1.Add pci device id AEC67162 0x808a
AEC67160 0x8080
AEC67160S 0x8081

2.Add some structure in atp_unit,because AEC67162 was dual channel LVD160 SCSI adapter.

3.Add some function about AEC67162, is885() tscam_885().

4.In probe function,interrupt function,queuecommand function,send_s870 function
,add some access register action about AEC67162.