From: domen@coderock.org
To: James.Bottomley@SteelEye.com
Cc: linux-scsi@vger.kernel.org, domen@coderock.org, nacc@us.ibm.com,
janitor@sternwelten.at
Subject: [patch 2/7] scsi/ppa: replace schedule_timeout() with msleep()
Date: Wed, 12 Jan 2005 00:22:50 +0100 [thread overview]
Message-ID: <20050111232251.3BBB31F226@trashy.coderock.org> (raw)
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected.
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/scsi/ppa.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/scsi/ppa.c~msleep-drivers_scsi_ppa drivers/scsi/ppa.c
--- kj/drivers/scsi/ppa.c~msleep-drivers_scsi_ppa 2005-01-10 18:00:05.000000000 +0100
+++ kj-domen/drivers/scsi/ppa.c 2005-01-10 18:00:05.000000000 +0100
@@ -1034,7 +1034,7 @@ static int __ppa_attach(struct parport *
dev->waiting = &waiting;
prepare_to_wait(&waiting, &wait, TASK_UNINTERRUPTIBLE);
if (ppa_pb_claim(dev))
- schedule_timeout(3 * HZ);
+ msleep(3000);
if (dev->wanted) {
printk(KERN_ERR "ppa%d: failed to claim parport because "
"a pardevice is owning the port for too long "
_
next reply other threads:[~2005-01-11 23:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-11 23:22 domen [this message]
2005-01-12 16:24 ` [patch 2/7] scsi/ppa: replace schedule_timeout() with msleep() James Bottomley
2005-01-12 23:40 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050111232251.3BBB31F226@trashy.coderock.org \
--to=domen@coderock.org \
--cc=James.Bottomley@SteelEye.com \
--cc=janitor@sternwelten.at \
--cc=linux-scsi@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox