* [patch 2/7] scsi/ppa: replace schedule_timeout() with msleep()
@ 2005-01-11 23:22 domen
2005-01-12 16:24 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: domen @ 2005-01-11 23:22 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, domen, nacc, janitor
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected.
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/scsi/ppa.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/scsi/ppa.c~msleep-drivers_scsi_ppa drivers/scsi/ppa.c
--- kj/drivers/scsi/ppa.c~msleep-drivers_scsi_ppa 2005-01-10 18:00:05.000000000 +0100
+++ kj-domen/drivers/scsi/ppa.c 2005-01-10 18:00:05.000000000 +0100
@@ -1034,7 +1034,7 @@ static int __ppa_attach(struct parport *
dev->waiting = &waiting;
prepare_to_wait(&waiting, &wait, TASK_UNINTERRUPTIBLE);
if (ppa_pb_claim(dev))
- schedule_timeout(3 * HZ);
+ msleep(3000);
if (dev->wanted) {
printk(KERN_ERR "ppa%d: failed to claim parport because "
"a pardevice is owning the port for too long "
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 2/7] scsi/ppa: replace schedule_timeout() with msleep()
2005-01-11 23:22 [patch 2/7] scsi/ppa: replace schedule_timeout() with msleep() domen
@ 2005-01-12 16:24 ` James Bottomley
2005-01-12 23:40 ` Nishanth Aravamudan
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2005-01-12 16:24 UTC (permalink / raw)
To: domen; +Cc: SCSI Mailing List, nacc, janitor
On Wed, 2005-01-12 at 00:22 +0100, domen@coderock.org wrote:
> - schedule_timeout(3 * HZ);
> + msleep(3000);
This would make more sense as ssleep(3), wouldn't it?
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 2/7] scsi/ppa: replace schedule_timeout() with msleep()
2005-01-12 16:24 ` James Bottomley
@ 2005-01-12 23:40 ` Nishanth Aravamudan
0 siblings, 0 replies; 3+ messages in thread
From: Nishanth Aravamudan @ 2005-01-12 23:40 UTC (permalink / raw)
To: James Bottomley; +Cc: domen, SCSI Mailing List, janitor
On Wed, Jan 12, 2005 at 10:24:50AM -0600, James Bottomley wrote:
> On Wed, 2005-01-12 at 00:22 +0100, domen@coderock.org wrote:
> > - schedule_timeout(3 * HZ);
> > + msleep(3000);
>
> This would make more sense as ssleep(3), wouldn't it?
Actually, this patch should be dropped! :) msleep() will ignore any wait-queue
events (triggered because of the prepare_to_wait() call). So please revert, if
applied.
Thanks,
Nish
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-12 23:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-11 23:22 [patch 2/7] scsi/ppa: replace schedule_timeout() with msleep() domen
2005-01-12 16:24 ` James Bottomley
2005-01-12 23:40 ` Nishanth Aravamudan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox