From: Nishanth Aravamudan <nacc@us.ibm.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: domen@coderock.org,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
janitor@sternwelten.at
Subject: Re: [patch 2/7] scsi/ppa: replace schedule_timeout() with msleep()
Date: Wed, 12 Jan 2005 15:40:43 -0800 [thread overview]
Message-ID: <20050112234043.GA2688@us.ibm.com> (raw)
In-Reply-To: <1105547090.5577.13.camel@mulgrave>
On Wed, Jan 12, 2005 at 10:24:50AM -0600, James Bottomley wrote:
> On Wed, 2005-01-12 at 00:22 +0100, domen@coderock.org wrote:
> > - schedule_timeout(3 * HZ);
> > + msleep(3000);
>
> This would make more sense as ssleep(3), wouldn't it?
Actually, this patch should be dropped! :) msleep() will ignore any wait-queue
events (triggered because of the prepare_to_wait() call). So please revert, if
applied.
Thanks,
Nish
prev parent reply other threads:[~2005-01-12 23:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-11 23:22 [patch 2/7] scsi/ppa: replace schedule_timeout() with msleep() domen
2005-01-12 16:24 ` James Bottomley
2005-01-12 23:40 ` Nishanth Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050112234043.GA2688@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=domen@coderock.org \
--cc=janitor@sternwelten.at \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox