From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: Re: [PATCH] SCSI NCR53C9x.c: some cleanups Date: Mon, 17 Jan 2005 13:54:49 +0100 Message-ID: <20050117125449.GP4274@stusta.de> References: <200412290732.iBT7WifI018047@hera.kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailout.stusta.mhn.de ([141.84.69.5]:37134 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S262788AbVAQMyy (ORCPT ); Mon, 17 Jan 2005 07:54:54 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Geert Uytterhoeven Cc: James Bottomley , Linus Torvalds , Andrew Morton , linux-scsi@vger.kernel.org, Linux Kernel Development , Linux/m68k On Mon, Jan 17, 2005 at 01:41:29PM +0100, Geert Uytterhoeven wrote: > On Tue, 21 Dec 2004, Linux Kernel Mailing List wrote: > > ChangeSet 1.2034.61.36, 2004/12/21 09:41:18-06:00, bunk@stusta.de > > > > [PATCH] SCSI NCR53C9x.c: some cleanups > > > > Make two functions static > > > --- a/drivers/scsi/NCR53C9x.c 2004-12-28 23:32:55 -08:00 > > +++ b/drivers/scsi/NCR53C9x.c 2004-12-28 23:32:55 -08:00 > > @@ -505,7 +505,7 @@ > > } > > > > /* This places the ESP into a known state at boot time. */ > > -void esp_bootup_reset(struct NCR_ESP *esp, struct ESP_regs *eregs) > > +static void esp_bootup_reset(struct NCR_ESP *esp, struct ESP_regs *eregs) > > { > > volatile unchar trash; > > > > This change breaks the Amiga Oktagon SCSI driver (drivers/scsi/oktagon_esp.c), > which calls esp_bootup_reset(). My bad - I did grep for esp_bootup_reset, but I confused the function prototype in oktagon_esp.c with a local function in this file. @Linus: Please exclude my buggy patch. > Gr{oetje,eeting}s, > > Geert cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed